Issue 10827126: mac: Don't use |NSHost currentHost|, as it takes 4s per test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827126: mac: Don't use |NSHost currentHost|, as it takes 4s per test (Closed)

Created:
8 years, 4 months ago by Nico

Modified:
8 years, 4 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Ilya Sherman, Bernhard Bauer, akalin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

mac: Don't use |NSHost currentHost|, as it takes 4s per test Also see http://codereview.chromium.org/7000022 BUG=81634, 138570 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149543

Patch Set 2 : comments #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -9 lines)			Patch
	M	sync/util/get_session_name_mac.mm	View	1	1 chunk	+8 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

akalin

lgtm https://chromiumcodereview.appspot.com/10827126/diff/1/sync/util/get_session_name_mac.mm File sync/util/get_session_name_mac.mm (right): https://chromiumcodereview.appspot.com/10827126/diff/1/sync/util/get_session_name_mac.mm#newcode7 sync/util/get_session_name_mac.mm:7: #import <Foundation/Foundation.h> are all of these imports/includes still ...

8 years, 4 months ago (2012-08-01 23:06:11 UTC) #2

Nico

thanks. Deleted includes / renamed variables in patch set 2. cqing.

8 years, 4 months ago (2012-08-01 23:07:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10827126/5001

8 years, 4 months ago (2012-08-01 23:07:53 UTC) #5

Change committed as 149543

Expand Messages | Collapse Messages

Issue 10827126: mac: Don't use |NSHost currentHost|, as it takes 4s per test (Closed)

Description

Patch Set 1 #

Patch Set 2 : comments #

Messages