Use JavaObjectWeakGlobalRef in ContentViewCore.

content/browser/android/download_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/download_controller.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 168 matching lines @@
         BrowserThread::UI, FROM_HERE,
         base::Bind(&DownloadController::StartAndroidDownload,
                    base::Unretained(this), info, render_process_id,
                    render_view_id));
     return;
   }
 
   JNIEnv* env = AttachCurrentThread();
 
   // Call newHttpGetDownload
-  jobject view = GetContentView(render_process_id, render_view_id);
-  if (!view) {
+  ScopedJavaLocalRef<jobject> view = GetContentView(render_process_id,
+                                                    render_view_id);
+  if (view.is_null()) {
     // The view went away. Can't proceed.
     LOG(ERROR) << "Download failed on URL:" << info.url.spec();
     return;
   }
 
   ScopedJavaLocalRef<jstring> jurl =
       ConvertUTF8ToJavaString(env, info.url.spec());
   ScopedJavaLocalRef<jstring> juser_agent =
       ConvertUTF8ToJavaString(env, info.user_agent);
   ScopedJavaLocalRef<jstring> jcontent_disposition =
       ConvertUTF8ToJavaString(env, info.content_disposition);
   ScopedJavaLocalRef<jstring> jmime_type =
       ConvertUTF8ToJavaString(env, info.original_mime_type);
   ScopedJavaLocalRef<jstring> jcookie =
       ConvertUTF8ToJavaString(env, info.cookie);
 
   Java_DownloadController_newHttpGetDownload(
-      env, GetJavaObject()->Controller(env).obj(), view, jurl.obj(),
+      env, GetJavaObject()->Controller(env).obj(), view.obj(), jurl.obj(),
       juser_agent.obj(), jcontent_disposition.obj(), jmime_type.obj(),
       jcookie.obj(), info.total_bytes);
 }
 
 void DownloadController::OnPostDownloadStarted(
     WebContents* web_contents,
     DownloadItem* download_item) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   JNIEnv* env = AttachCurrentThread();
 
   // Register for updates to the DownloadItem.
   download_item->AddObserver(this);
 
-  jobject view = GetContentViewCoreFromWebContents(web_contents);
-  if(!view) {
+  ScopedJavaLocalRef<jobject> view =
+      GetContentViewCoreFromWebContents(web_contents);
+  if(view.is_null()) {
     // The view went away. Can't proceed.
     return;
   }
 
   Java_DownloadController_onHttpPostDownloadStarted(
-      env, GetJavaObject()->Controller(env).obj(), view);
+      env, GetJavaObject()->Controller(env).obj(), view.obj());
 }
 
 void DownloadController::OnDownloadUpdated(DownloadItem* item) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   if (item->GetState() != DownloadItem::COMPLETE)
     return;
 
   // Call onHttpPostDownloadCompleted
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jstring> jurl =
       ConvertUTF8ToJavaString(env, item->GetURL().spec());
   ScopedJavaLocalRef<jstring> jcontent_disposition =
       ConvertUTF8ToJavaString(env, item->GetContentDisposition());
   ScopedJavaLocalRef<jstring> jmime_type =
       ConvertUTF8ToJavaString(env, item->GetMimeType());
   ScopedJavaLocalRef<jstring> jpath =
       ConvertUTF8ToJavaString(env, item->GetFullPath().value());
 
-  jobject view_core = GetContentViewCoreFromWebContents(item->GetWebContents());
-  if (!view_core) {
+  ScopedJavaLocalRef<jobject> view_core = GetContentViewCoreFromWebContents(
+      item->GetWebContents());
+  if (view_core.is_null()) {
     // We can get NULL WebContents from the DownloadItem.
     return;
   }
 
   Java_DownloadController_onHttpPostDownloadCompleted(env,
-      GetJavaObject()->Controller(env).obj(), view_core, jurl.obj(),
+      GetJavaObject()->Controller(env).obj(), view_core.obj(), jurl.obj(),
       jcontent_disposition.obj(), jmime_type.obj(), jpath.obj(),
       item->GetReceivedBytes(), true);
 }
 
 void DownloadController::OnDownloadOpened(DownloadItem* item) {
 }
 
-jobject DownloadController::GetContentView(int render_process_id,
-                                           int render_view_id) {
+ScopedJavaLocalRef<jobject> DownloadController::GetContentView(
+    int render_process_id, int render_view_id) {
   RenderViewHost* render_view_host =
       RenderViewHost::FromID(render_process_id, render_view_id);
 
   if (!render_view_host)
-    return NULL;
+    return ScopedJavaLocalRef<jobject>();
 
   WebContents* web_contents =
       render_view_host->GetDelegate()->GetAsWebContents();
 
   if (!web_contents)
-    return NULL;
+    return ScopedJavaLocalRef<jobject>();
 
   return GetContentViewCoreFromWebContents(web_contents);
 }
 
-jobject DownloadController::GetContentViewCoreFromWebContents(
+ScopedJavaLocalRef<jobject>
+    DownloadController::GetContentViewCoreFromWebContents(
     WebContents* web_contents) {
+  if (!web_contents)
+    return ScopedJavaLocalRef<jobject>();
+
   NOTIMPLEMENTED();
-  return NULL;
+  return ScopedJavaLocalRef<jobject>();
 }
 
 DownloadController::JavaObject* DownloadController::GetJavaObject() {
   if (!java_object_) {
     // Initialize Java DownloadController by calling
     // DownloadController.getInstance(), which will call Init()
     // if Java DownloadController is not instantiated already.
     JNIEnv* env = AttachCurrentThread();
     ScopedJavaLocalRef<jclass> clazz =
         GetClass(env, kDownloadControllerClassPathName);
@@ skipping 15 matching lines @@
   request->extra_request_headers().GetHeader(
       net::HttpRequestHeaders::kUserAgent,
       &user_agent);
   if (!request->url_chain().empty()) {
     original_url = request->url_chain().front();
     url = request->url_chain().back();
   }
 }
 
 }  // namespace content