chrome/browser/extensions/api/serial/serial_connection.cc - Issue 10827123: Add serial bulk reads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/serial/serial_connection.cc

Issue 10827123: Add serial bulk reads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge help. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/serial/serial_connection.cc

diff --git a/chrome/browser/extensions/api/serial/serial_connection.cc b/chrome/browser/extensions/api/serial/serial_connection.cc

index b25df0687bb4e7a8e20ad4ffe5616f53adf23fbf..6834a61eba20120bdaecf68dd7f01b5c5c7d2ddc 100644

--- a/chrome/browser/extensions/api/serial/serial_connection.cc

+++ b/chrome/browser/extensions/api/serial/serial_connection.cc

@@ -54,10 +54,11 @@ void SerialConnection::Close() {

}

-int SerialConnection::Read(uint8* byte) {

- DCHECK(byte);

+int SerialConnection::Read(scoped_refptr<net::IOBufferWithSize> io_buffer) {

+ DCHECK(io_buffer->data());

return base::ReadPlatformFileAtCurrentPos(file_,

- reinterpret_cast<char*>(byte), 1);

+ io_buffer->data(),

+ io_buffer->size());

}

int SerialConnection::Write(scoped_refptr<net::IOBuffer> io_buffer,