Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Side by Side Diff: chrome/browser/resources/options2/chromeos/internet_detail.js

Issue 10827118: Hide network tab on details dialog for VPN networks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options.internet', function() { 5 cr.define('options.internet', function() {
6 var OptionsPage = options.OptionsPage; 6 var OptionsPage = options.OptionsPage;
7 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel; 7 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
8 8
9 /** 9 /**
10 * Network settings constants. These enums must match their C++ 10 * Network settings constants. These enums must match their C++
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
297 297
298 // Network type related. 298 // Network type related.
299 updateHidden('#details-internet-page .cellular-details', !this.cellular); 299 updateHidden('#details-internet-page .cellular-details', !this.cellular);
300 updateHidden('#details-internet-page .wifi-details', !this.wireless); 300 updateHidden('#details-internet-page .wifi-details', !this.wireless);
301 updateHidden('#details-internet-page .wimax-details', !this.wimax); 301 updateHidden('#details-internet-page .wimax-details', !this.wimax);
302 updateHidden('#details-internet-page .vpn-details', !this.vpn); 302 updateHidden('#details-internet-page .vpn-details', !this.vpn);
303 updateHidden('#details-internet-page .proxy-details', !this.showProxy); 303 updateHidden('#details-internet-page .proxy-details', !this.showProxy);
304 /* Network information merged into the Wifi tab for wireless networks 304 /* Network information merged into the Wifi tab for wireless networks
305 unless the option is set for enabling a static IP configuration. */ 305 unless the option is set for enabling a static IP configuration. */
306 updateHidden('#details-internet-page .network-details', 306 updateHidden('#details-internet-page .network-details',
307 this.wireless && !this.showStaticIPConfig); 307 (this.wireless && !this.showStaticIPConfig) || this.vpn);
308 updateHidden('#details-internet-page .wifi-network-setting', 308 updateHidden('#details-internet-page .wifi-network-setting',
309 this.showStaticIPConfig); 309 this.showStaticIPConfig);
310 310
311 // Cell plan related. 311 // Cell plan related.
312 $('plan-list').hidden = this.cellplanloading; 312 $('plan-list').hidden = this.cellplanloading;
313 updateHidden('#details-internet-page .no-plan-info', 313 updateHidden('#details-internet-page .no-plan-info',
314 !this.cellular || this.cellplanloading || this.hascellplan); 314 !this.cellular || this.cellplanloading || this.hascellplan);
315 updateHidden('#details-internet-page .plan-loading-info', 315 updateHidden('#details-internet-page .plan-loading-info',
316 !this.cellular || this.nocellplan || this.hascellplan); 316 !this.cellular || this.nocellplan || this.hascellplan);
317 updateHidden('#details-internet-page .plan-details-info', 317 updateHidden('#details-internet-page .plan-details-info',
(...skipping 585 matching lines...) Expand 10 before | Expand all | Expand 10 after
903 903
904 // Don't show page name in address bar and in history to prevent people 904 // Don't show page name in address bar and in history to prevent people
905 // navigate here by hand and solve issue with page session restore. 905 // navigate here by hand and solve issue with page session restore.
906 OptionsPage.showPageByName('detailsInternetPage', false); 906 OptionsPage.showPageByName('detailsInternetPage', false);
907 }; 907 };
908 908
909 return { 909 return {
910 DetailsInternetPage: DetailsInternetPage 910 DetailsInternetPage: DetailsInternetPage
911 }; 911 };
912 }); 912 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698