Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 10827118: Hide network tab on details dialog for VPN networks. (Closed)

Created:
8 years, 4 months ago by kevers
Modified:
8 years, 4 months ago
Reviewers:
csilv
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Hide network tab on details dialog for VPN networks. BUG=chromium-os:21273 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/options2/chromeos/internet_detail.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kevers
Hi Chris, Can you please have a look at this CL. IP configuration details are ...
8 years, 4 months ago (2012-08-01 15:23:16 UTC) #1
csilv
lgtm
8 years, 4 months ago (2012-08-01 18:38:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/10827118/1
8 years, 4 months ago (2012-08-02 15:32:38 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-02 17:06:29 UTC) #4
Change committed as 149640

Powered by Google App Engine
This is Rietveld 408576698