Issue 10827113: Fix the 137002 fix (Don't generate ICs for accessors on slow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827113: Fix the 137002 fix (Don't generate ICs for accessors on slow (Closed)

Created:
8 years, 4 months ago by Erik Corry

Modified:
8 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Fix the 137002 fix (Don't generate ICs for accessors on slow case objects). We should be testing the holder for dictionary mode, not the receiver. Committed: https://code.google.com/p/v8/source/detail?r=12247

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -11 lines)			Patch
	M	src/ic.cc	View	1	6 chunks	+9 lines, -6 lines	0 comments	Download
	M	test/cctest/test-api.cc	View	1	1 chunk	+41 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

LGTM (nice catch).

Expand Messages | Collapse Messages