base: Fix minor warnings reported by cppcheck.

base: Fix minor warnings reported by cppcheck.

Found with:

$ cppcheck --enable=all -j4 --force base 2> base-errors

R=jar@chromium.org
NOTRY=True


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150059

[tfarina, 2012-08-03 14:38:54]

+jar for review!

[jar (doing other things), 2012-08-03 17:20:19]

Please fix the nit below, and then LGTM.

Also as an FYI if you're the person hacking cppcheck, I had another comment
below.

http://codereview.chromium.org/10827112/diff/1/base/observer_list_unittest.cc
File base/observer_list_unittest.cc (right):

http://codereview.chromium.org/10827112/diff/1/base/observer_list_unittest.cc...
base/observer_list_unittest.cc:34: int total;
I'm surprised you didn't get a warning on this.... member of class is not
private (and does not have trailing underscore like other member).

... and we cannot use the gtest exception, since this is not a class derived to
be used as a testing harness.

http://codereview.chromium.org/10827112/diff/1/base/process_util_posix.cc
File base/process_util_posix.cc (right):

http://codereview.chromium.org/10827112/diff/1/base/process_util_posix.cc#new...
base/process_util_posix.cc:266: static const unsigned kMaxSleepMs = 1000;
nit: No need for static.  Also, declare as close as possible to first use (in
this case, only use) before line 288.

[tfarina, 2012-08-04 02:30:47]

http://codereview.chromium.org/10827112/diff/1/base/observer_list_unittest.cc
File base/observer_list_unittest.cc (right):

http://codereview.chromium.org/10827112/diff/1/base/observer_list_unittest.cc...
base/observer_list_unittest.cc:34: int total;
On 2012/08/03 17:20:19, jar wrote:
> I'm surprised you didn't get a warning on this.... member of class is not
> private (and does not have trailing underscore like other member).
> 
I think this is because cppcheck does not know our C++ coding guide lines :)

Thus, it cannot fire a warning about:
1 - total is a public variable. Which is bad.
2 - if it's a data member variable, it should end with a underscore.

We should probably fix these style issues. I'll do this in a follow up CL. We
should move total to private section, provide a const getter accessor and rename
it to total_.

> ... and we cannot use the gtest exception, since this is not a class derived
to
> be used as a testing harness.
By gtest exception, I don't know what you mean.

[commit-bot: I haz the power, 2012-08-06 00:15:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/10827112/7001

[commit-bot: I haz the power, 2012-08-06 01:03:06]

Change committed as 150059