Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 10827109: Simplify Pnacl translation thread code (Closed)

Created:
8 years, 4 months ago by Derek Schuff
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Simplify Pnacl translation thread code Primarily a merge of the streaming-related code into PnaclTranslationThread R=jvoung@chromium.org,sehr@chromium.org BUG=http://code.google.com/p/nativeclient/issues/detail?id=2195 TEST=nacl_integration Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149464

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -271 lines) Patch
M ppapi/native_client/src/trusted/plugin/build.scons View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 3 chunks +3 lines, -6 lines 0 comments Download
D ppapi/native_client/src/trusted/plugin/pnacl_streaming_translate_thread.h View 1 chunk +0 lines, -58 lines 0 comments Download
D ppapi/native_client/src/trusted/plugin/pnacl_streaming_translate_thread.cc View 1 chunk +0 lines, -196 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.h View 4 chunks +34 lines, -8 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc View 4 chunks +174 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Derek Schuff
Didn't touch the synchronization code here; the next CL will be to make SetSubprocessesShouldDie actually ...
8 years, 4 months ago (2012-07-31 23:50:35 UTC) #1
jvoung (off chromium)
lgtm
8 years, 4 months ago (2012-08-01 01:19:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dschuff@chromium.org/10827109/7001
8 years, 4 months ago (2012-08-01 18:26:08 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 19:36:03 UTC) #4
Change committed as 149464

Powered by Google App Engine
This is Rietveld 408576698