Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2353)

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor.cc

Issue 10827103: Speculative resource prefetching - fixing missing navigations due to server side redirects. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Addressing James's comments. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetch_predictor.cc
diff --git a/chrome/browser/predictors/resource_prefetch_predictor.cc b/chrome/browser/predictors/resource_prefetch_predictor.cc
index a65f5d5967bff06fc78f6409c9c9fb3dcf4c4697..cbbd46e1baf4997017557d0d6066c273e4249c97 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor.cc
+++ b/chrome/browser/predictors/resource_prefetch_predictor.cc
@@ -84,11 +84,12 @@ ResourcePrefetchPredictor::URLRequestSummary::URLRequestSummary()
ResourcePrefetchPredictor::URLRequestSummary::URLRequestSummary(
const URLRequestSummary& other)
- : navigation_id(other.navigation_id),
- resource_url(other.resource_url),
- resource_type(other.resource_type),
- mime_type(other.mime_type),
- was_cached(other.was_cached) {
+ : navigation_id(other.navigation_id),
+ resource_url(other.resource_url),
+ resource_type(other.resource_type),
+ mime_type(other.mime_type),
+ was_cached(other.was_cached),
+ redirect_url(other.redirect_url) {
}
ResourcePrefetchPredictor::URLRequestSummary::~URLRequestSummary() {
@@ -345,7 +346,20 @@ void ResourcePrefetchPredictor::OnMainFrameRedirect(
const URLRequestSummary& response) {
CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ // Remove the older navigation.
inflight_navigations_.erase(response.navigation_id);
+
+ // A redirect will not lead to another OnMainFrameRequest call, so record the
+ // redirect url as a new navigation.
+
+ // The redirect url may be empty if the url was invalid.
+ if (response.redirect_url.is_empty())
+ return;
+
+ NavigationID navigation_id(response.navigation_id);
+ navigation_id.main_frame_url = response.redirect_url;
+ inflight_navigations_.insert(std::make_pair(
+ navigation_id, std::vector<URLRequestSummary>()));
}
void ResourcePrefetchPredictor::OnSubresourceResponse(

Powered by Google App Engine
This is Rietveld 408576698