Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 10827080: Extract ChromeBrowserFieldTrials out of ChromeBrowserMainParts. (Closed)

Created:
8 years, 4 months ago by Alexei Svitkine (slow)
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Extract ChromeBrowserFieldTrials out of ChromeBrowserMainParts. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149216

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+689 lines, -661 lines) Patch
M chrome/browser/browser_process_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/browser_trial.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/browser_trial.cc View 1 chunk +0 lines, -11 lines 0 comments Download
A chrome/browser/chrome_browser_field_trials.h View 1 chunk +73 lines, -0 lines 0 comments Download
A chrome/browser/chrome_browser_field_trials.cc View 1 chunk +604 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 4 chunks +3 lines, -46 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 13 chunks +3 lines, -572 lines 0 comments Download
M chrome/browser/chrome_browser_main_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
8 years, 4 months ago (2012-07-29 23:11:09 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-07-31 15:43:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10827080/24
8 years, 4 months ago (2012-07-31 16:23:37 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-31 17:48:16 UTC) #4
Change committed as 149216

Powered by Google App Engine
This is Rietveld 408576698