Issue 10827079: Ignore unrecognized protection schemes in ISO BMFF files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827079: Ignore unrecognized protection schemes in ISO BMFF files. (Closed)

Created:
8 years, 4 months ago by strobe_

Modified:
8 years, 4 months ago

Reviewers:
ddorwin

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Ignore unrecognized protection schemes in ISO BMFF files. BUG= TEST=Manual, in browser Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148874

Patch Set 2 : Review comment #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -7 lines)			Patch
	M	media/mp4/box_definitions.cc	View	1	4 chunks	+25 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ddorwin

lgtm % comment http://codereview.chromium.org/10827079/diff/1/media/mp4/box_definitions.cc File media/mp4/box_definitions.cc (right): http://codereview.chromium.org/10827079/diff/1/media/mp4/box_definitions.cc#newcode392 media/mp4/box_definitions.cc:392: RCHECK(reader->ReadChild(&sinf)); This causes a DLOG(ERROR) even ...

8 years, 4 months ago (2012-07-28 00:41:21 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/strobe@google.com/10827079/6002

8 years, 4 months ago (2012-07-28 01:14:21 UTC) #3

Change committed as 148874

Expand Messages | Collapse Messages

Issue 10827079: Ignore unrecognized protection schemes in ISO BMFF files. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review comment #

Messages