content/common/string_constants.h - Issue 10827078: Support frame tree propagation between renderers in the same browsing instance.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/string_constants.h

Issue 10827078: Support frame tree propagation between renderers in the same browsing instance. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Moved away from hardcoded strings and no static cast needed for tests. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/web_contents/web_contents_impl.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/string_constants.cc » ('j') | content/common/view_messages.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_COMMON_STRING_CONSTANTS_H_
	awong 2012/08/21 19:27:28 string_constants is too generic. We should name i string_constants is too generic. We should name it something like FrameTree constants, or render view constants, or something indicates the types of constants that should be in here. nasko 2012/08/21 22:24:13 Done. Show quoted text On 2012/08/21 19:27:28, awong wrote: > string_constants is too generic. We should name it something like FrameTree > constants, or render view constants, or something indicates the types of > constants that should be in here. Done.
	6 #define CONTENT_COMMON_STRING_CONSTANTS_H_

	7

	8 namespace content {

	9

	10 extern const char kFrameTreeNodeNameKey[];
	awong 2012/08/21 19:27:28 Add comment referring to location that describes w Add comment referring to location that describes why these constants exist (probably the comment block in the ipc message) nasko 2012/08/21 22:24:13 Done. Show quoted text On 2012/08/21 19:27:28, awong wrote: > Add comment referring to location that describes why these constants exist > (probably the comment block in the ipc message) Done.
	11 extern const char kFrameTreeNodeIdKey[];

	12 extern const char kFrameTreeNodeSubtreeKey[];

	13

	14 } // namespace content

	15

	16 #endif // CONTENT_COMMON_STRING_CONSTANTS_H_

OLD	NEW