Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 10827075: Use isDiscoveryInNTPEnabled flag instead of isSuggestionsPageEnabled flag to control suggestions (Closed)

Created:
8 years, 4 months ago by srvasude1
Modified:
8 years, 4 months ago
Reviewers:
beaudoin, Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews)
Visibility:
Public.

Description

The isSuggestionsPageEnabled flag will be deprecated/be reassigned to suggestions coming from user history. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/browser/resources/ntp4/new_tab.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
beaudoin
lgtm
8 years, 4 months ago (2012-08-07 20:55:46 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-08-07 21:35:17 UTC) #2
Evan Stade
Hi Srinivas, a couple comments. 1. If you would like a review, you should press ...
8 years, 4 months ago (2012-08-07 23:58:52 UTC) #3
srvasude1
On 2012/08/07 23:58:52, Evan Stade wrote: > Hi Srinivas, > > a couple comments. > ...
8 years, 4 months ago (2012-08-08 05:36:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srvasude@chromium.org/10827075/1
8 years, 4 months ago (2012-08-08 05:36:41 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 07:21:51 UTC) #6
Change committed as 150512

Powered by Google App Engine
This is Rietveld 408576698