content/common/gpu/media/mac_video_decode_accelerator.mm - Issue 10827074: Replace the explicit *VDA::Set{CGL,Egl,Glx}Context() methods with ctor params.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/mac_video_decode_accelerator.mm

Issue 10827074: Replace the explicit *VDA::Set{CGL,Egl,Glx}Context() methods with ctor params. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/mac_video_decode_accelerator.h ('k') | content/common/gpu/media/omx_video_decode_accelerator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/mac_video_decode_accelerator.mm

diff --git a/content/common/gpu/media/mac_video_decode_accelerator.mm b/content/common/gpu/media/mac_video_decode_accelerator.mm

index 7aa9c6c66d69a07b860cf79ad0ea3fd43e238bdb..2f2ce98439c3bde6fbeeee6789a28d8a55508d6a 100644

--- a/content/common/gpu/media/mac_video_decode_accelerator.mm

+++ b/content/common/gpu/media/mac_video_decode_accelerator.mm

@@ -93,13 +93,13 @@ static bool BindImageToTexture(CGLContextObj context,

}

MacVideoDecodeAccelerator::MacVideoDecodeAccelerator(

- media::VideoDecodeAccelerator::Client* client)

+ CGLContextObj cgl_context, media::VideoDecodeAccelerator::Client* client)

: client_(client),

- cgl_context_(NULL),

+ cgl_context_(cgl_context),

did_build_config_record_(false) {

}

-void MacVideoDecodeAccelerator::SetCGLContext(CGLContextObj cgl_context) {

+void MacVideoDecodeAccelerator::SetCGLContext() {

Pawel Osciak 2012/07/27 20:08:15 Not needed anymore...

Ami GONE FROM CHROMIUM 2012/07/27 20:22:39 Done. (the joys of editing code without the benefi

DCHECK(CalledOnValidThread());

cgl_context_ = cgl_context;

}

« no previous file with comments | « content/common/gpu/media/mac_video_decode_accelerator.h ('k') | content/common/gpu/media/omx_video_decode_accelerator.h » ('j') | no next file with comments »