Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 10827074: Replace the explicit *VDA::Set{CGL,Egl,Glx}Context() methods with ctor params. (Closed)

Created:
8 years, 4 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Replace the explicit *VDA::Set{CGL,Egl,Glx}Context() methods with ctor params. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148911

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -67 lines) Patch
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 chunk +11 lines, -17 lines 0 comments Download
M content/common/gpu/media/mac_video_decode_accelerator.h View 1 chunk +2 lines, -4 lines 0 comments Download
M content/common/gpu/media/mac_video_decode_accelerator.mm View 1 1 chunk +2 lines, -7 lines 0 comments Download
M content/common/gpu/media/omx_video_decode_accelerator.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/common/gpu/media/omx_video_decode_accelerator.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/common/gpu/media/vaapi_video_decode_accelerator.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 chunk +13 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ami GONE FROM CHROMIUM
posciak: please review scherkus: please super-star review
8 years, 4 months ago (2012-07-27 19:39:08 UTC) #1
Pawel Osciak
https://chromiumcodereview.appspot.com/10827074/diff/1/content/common/gpu/media/mac_video_decode_accelerator.mm File content/common/gpu/media/mac_video_decode_accelerator.mm (right): https://chromiumcodereview.appspot.com/10827074/diff/1/content/common/gpu/media/mac_video_decode_accelerator.mm#newcode102 content/common/gpu/media/mac_video_decode_accelerator.mm:102: void MacVideoDecodeAccelerator::SetCGLContext() { Not needed anymore...
8 years, 4 months ago (2012-07-27 20:08:15 UTC) #2
Ami GONE FROM CHROMIUM
https://chromiumcodereview.appspot.com/10827074/diff/1/content/common/gpu/media/mac_video_decode_accelerator.mm File content/common/gpu/media/mac_video_decode_accelerator.mm (right): https://chromiumcodereview.appspot.com/10827074/diff/1/content/common/gpu/media/mac_video_decode_accelerator.mm#newcode102 content/common/gpu/media/mac_video_decode_accelerator.mm:102: void MacVideoDecodeAccelerator::SetCGLContext() { On 2012/07/27 20:08:15, posciak wrote: > ...
8 years, 4 months ago (2012-07-27 20:22:39 UTC) #3
Pawel Osciak
lgtm
8 years, 4 months ago (2012-07-27 20:24:24 UTC) #4
scherkus (not reviewing)
j'approuve ce changement! lgtm!
8 years, 4 months ago (2012-07-28 22:46:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10827074/4001
8 years, 4 months ago (2012-07-28 23:13:37 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-07-29 02:04:49 UTC) #7
Change committed as 148911

Powered by Google App Engine
This is Rietveld 408576698