Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 10827067: chromeos: Move common D-Bus method callbacks to dbus_method_call_status.h (Closed)

Created:
8 years, 4 months ago by hashimoto
Modified:
8 years, 4 months ago
Reviewers:
stevenjb, Evan Stade
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Move common D-Bus method callbacks to dbus_method_call_status.h BUG=None TEST=build success Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149376

Patch Set 1 : _ #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -172 lines) Patch
M chrome/browser/chromeos/cros/cros_network_functions_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/dbus/cryptohome_client.h View 1 5 chunks +8 lines, -15 lines 0 comments Download
M chromeos/dbus/cryptohome_client.cc View 1 14 chunks +19 lines, -17 lines 0 comments Download
M chromeos/dbus/dbus_method_call_status.h View 2 chunks +27 lines, -1 line 0 comments Download
M chromeos/dbus/flimflam_client_helper.h View 3 chunks +5 lines, -12 lines 0 comments Download
M chromeos/dbus/flimflam_client_helper.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chromeos/dbus/flimflam_device_client.h View 2 chunks +4 lines, -6 lines 0 comments Download
M chromeos/dbus/flimflam_device_client.cc View 1 9 chunks +15 lines, -13 lines 0 comments Download
M chromeos/dbus/flimflam_ipconfig_client.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chromeos/dbus/flimflam_ipconfig_client.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M chromeos/dbus/flimflam_manager_client.h View 2 chunks +6 lines, -8 lines 0 comments Download
M chromeos/dbus/flimflam_manager_client.cc View 8 chunks +28 lines, -20 lines 0 comments Download
M chromeos/dbus/flimflam_profile_client.h View 2 chunks +1 line, -2 lines 0 comments Download
M chromeos/dbus/flimflam_profile_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/dbus/flimflam_service_client.h View 3 chunks +8 lines, -8 lines 0 comments Download
M chromeos/dbus/flimflam_service_client.cc View 7 chunks +17 lines, -15 lines 0 comments Download
M chromeos/dbus/mock_cryptohome_client.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M chromeos/dbus/mock_cryptohome_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/mock_flimflam_device_client.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chromeos/dbus/mock_flimflam_ipconfig_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/dbus/mock_flimflam_manager_client.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chromeos/dbus/mock_flimflam_profile_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/mock_flimflam_service_client.h View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hashimoto
8 years, 4 months ago (2012-07-27 05:21:15 UTC) #1
stevenjb
LGTM, Thanks!
8 years, 4 months ago (2012-07-30 22:29:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10827067/2001
8 years, 4 months ago (2012-07-31 00:49:00 UTC) #3
commit-bot: I haz the power
Presubmit check for 10827067-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-31 00:49:14 UTC) #4
hashimoto
Evan, could you review chrome/browser/ui/webui as an owner?
8 years, 4 months ago (2012-07-31 08:57:10 UTC) #5
Evan Stade
feel free to TBR owners reviews for minor changes like this. LGTM
8 years, 4 months ago (2012-07-31 23:21:23 UTC) #6
hashimoto
On 2012/07/31 23:21:23, Evan Stade wrote: > feel free to TBR owners reviews for minor ...
8 years, 4 months ago (2012-08-01 03:57:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10827067/2002
8 years, 4 months ago (2012-08-01 03:58:11 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 05:18:43 UTC) #9
Change committed as 149376

Powered by Google App Engine
This is Rietveld 408576698