Extensions Docs Server: Pull info from _permission_features.json

Extensions Docs Server: Pull info from _permission_features.json

APIDataSource now pulls info from _permission_features.json and displays it in
the 'Permissions' section.

BUG=131095
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149000

[cduvall, 2012-07-27 00:49:14]

I'm not sure how you wanted this info to be displayed, so I just put it in a
section called Permissions. Easy to change though.

[not at google - send to devlin, 2012-07-30 12:43:23]

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/server2/api_data_source.py (right):

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/api_data_source.py:35: def
_GetChannel(self, path):
This is getting the Feature, not the Channel ("channel" is a field in the
feature).

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/api_data_source.py:40: self._base_path +
'/_permission_features.json')))
Could you put the loaded JSON in a cache (like the other caches)?

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/api_data_source.py:50: api_dict = {
'perms': self._GetChannel(path) }
no need to abbr perms

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/api_data_source.py:57: return api_dict
looks like this is a job for a helper method...

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/server2/templates/private/standard_api.html
(right):

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/templates/private/standard_api.html:20:
{{/}}
It's not very interesting for the common case where APIs are available on the
"stable" channel.

We should just generate something like

http://code.google.com/chrome/extensions/trunk/apps/app.window.html

for now, i.e. the warning up the top.

[cduvall, 2012-07-30 19:08:29]

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/server2/api_data_source.py (right):

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/api_data_source.py:35: def
_GetChannel(self, path):
On 2012/07/30 12:43:23, kalman wrote:
> This is getting the Feature, not the Channel ("channel" is a field in the
> feature).

Done.

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/api_data_source.py:40: self._base_path +
'/_permission_features.json')))
On 2012/07/30 12:43:23, kalman wrote:
> Could you put the loaded JSON in a cache (like the other caches)?

Done.

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/api_data_source.py:50: api_dict = {
'perms': self._GetChannel(path) }
On 2012/07/30 12:43:23, kalman wrote:
> no need to abbr perms

Done.

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/api_data_source.py:57: return api_dict
On 2012/07/30 12:43:23, kalman wrote:
> looks like this is a job for a helper method...

Done.

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/server2/templates/private/standard_api.html
(right):

http://codereview.chromium.org/10827063/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/templates/private/standard_api.html:20:
{{/}}
On 2012/07/30 12:43:23, kalman wrote:
> It's not very interesting for the common case where APIs are available on the
> "stable" channel.
> 
> We should just generate something like
> 
> http://code.google.com/chrome/extensions/trunk/apps/app.window.html
> 
> for now, i.e. the warning up the top.

Done.

[not at google - send to devlin, 2012-07-30 19:24:33]

lgtm

http://codereview.chromium.org/10827063/diff/9001/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/api_data_source.py (right):

http://codereview.chromium.org/10827063/diff/9001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/api_data_source.py:39: path =
path.replace('experimental_', '')
why delete the "experimental" references? add comment to explain?

http://codereview.chromium.org/10827063/diff/9001/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/templates/private/standard_api.html
(right):

http://codereview.chromium.org/10827063/diff/9001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/private/standard_api.html:15:
{{?api.permissions.dev}}
should probably go above the table of contents, since it's not really part of
the contents.

http://codereview.chromium.org/10827063/diff/9001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/private/standard_api.html:18:
the stable channel. -->
comment seems unnecessary

http://codereview.chromium.org/10827063/diff/9001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/private/standard_api.html:25: <a
href="TODO">Learn more</a>.
strange TODO. I'd delete.

[cduvall, 2012-07-30 19:37:37]

http://codereview.chromium.org/10827063/diff/9001/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/api_data_source.py (right):

http://codereview.chromium.org/10827063/diff/9001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/api_data_source.py:39: path =
path.replace('experimental_', '')
On 2012/07/30 19:24:33, kalman wrote:
> why delete the "experimental" references? add comment to explain?

Done.

http://codereview.chromium.org/10827063/diff/9001/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/templates/private/standard_api.html
(right):

http://codereview.chromium.org/10827063/diff/9001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/private/standard_api.html:15:
{{?api.permissions.dev}}
On 2012/07/30 19:24:33, kalman wrote:
> should probably go above the table of contents, since it's not really part of
> the contents.

Done.

http://codereview.chromium.org/10827063/diff/9001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/private/standard_api.html:18:
the stable channel. -->
On 2012/07/30 19:24:33, kalman wrote:
> comment seems unnecessary

Done.

http://codereview.chromium.org/10827063/diff/9001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/templates/private/standard_api.html:25: <a
href="TODO">Learn more</a>.
On 2012/07/30 19:24:33, kalman wrote:
> strange TODO. I'd delete.

Done.