Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 10827061: Moving mozrunner and simplejson to a toplevel location. (Closed)

Created:
8 years, 5 months ago by bradn
Modified:
8 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Moving mozrunner and simplejson to a toplevel location. To help our licensing scripts understand the layout of the project, moving things out of pylib directly into third_party. Also renaming README to README.nacl As this location is DEPSed into nacl and then into chrome, several follow-on CLs will be required to complete the move. BUG=https://code.google.com/p/chromium/issues/detail?id=138921 TEST=None R=ncbray@chromium.org,steveblock@chromium.org Committed: https://code.google.com/p/nativeclient/source/detail?r=9280

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -3247 lines) Patch
D src/third_party/mozrunner/README View 1 chunk +0 lines, -12 lines 0 comments Download
A + src/third_party/mozrunner/README.nacl View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/third_party/pylib/mozrunner/LICENSE View 1 chunk +0 lines, -35 lines 0 comments Download
D src/third_party/pylib/mozrunner/README View 1 chunk +0 lines, -12 lines 0 comments Download
D src/third_party/pylib/mozrunner/__init__.py View 1 chunk +0 lines, -639 lines 0 comments Download
D src/third_party/pylib/mozrunner/killableprocess.py View 1 chunk +0 lines, -292 lines 0 comments Download
D src/third_party/pylib/mozrunner/qijo.py View 1 chunk +0 lines, -162 lines 0 comments Download
D src/third_party/pylib/mozrunner/winprocess.py View 1 chunk +0 lines, -381 lines 0 comments Download
D src/third_party/pylib/mozrunner/wpk.py View 1 chunk +0 lines, -81 lines 0 comments Download
D src/third_party/pylib/simplejson/LICENSE View 1 chunk +0 lines, -19 lines 0 comments Download
D src/third_party/pylib/simplejson/README View 1 chunk +0 lines, -11 lines 0 comments Download
D src/third_party/pylib/simplejson/__init__.py View 1 chunk +0 lines, -437 lines 0 comments Download
D src/third_party/pylib/simplejson/decoder.py View 1 chunk +0 lines, -421 lines 0 comments Download
D src/third_party/pylib/simplejson/encoder.py View 1 chunk +0 lines, -501 lines 0 comments Download
D src/third_party/pylib/simplejson/ordered_dict.py View 1 chunk +0 lines, -119 lines 0 comments Download
D src/third_party/pylib/simplejson/scanner.py View 1 chunk +0 lines, -77 lines 0 comments Download
D src/third_party/pylib/simplejson/tool.py View 1 chunk +0 lines, -39 lines 0 comments Download
D src/third_party/simplejson/README View 1 chunk +0 lines, -11 lines 0 comments Download
A + src/third_party/simplejson/README.nacl View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bradn
8 years, 5 months ago (2012-07-27 00:20:17 UTC) #1
bradn
Note codereview doesn't seem to grok it, but there's an add for each of the ...
8 years, 5 months ago (2012-07-27 00:29:04 UTC) #2
Nick Bray (chromium)
LGTM nit: make it clear this is part of a multistep dance.
8 years, 5 months ago (2012-07-27 00:30:00 UTC) #3
Steve Block
8 years, 4 months ago (2012-07-27 09:20:27 UTC) #4
lgtm

Thanks Brad. You could maybe link to
https://code.google.com/p/chromium/issues/detail?id=138921 or a new
nacl-specific bug blocking this?

Powered by Google App Engine
This is Rietveld 408576698