Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: presubmit_canned_checks.py

Issue 10827059: Remove autogeneration of TEST= and automated check (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | tests/git_cl_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
===================================================================
--- presubmit_canned_checks.py (revision 148624)
+++ presubmit_canned_checks.py (working copy)
@@ -10,16 +10,6 @@
### Description checks
-def CheckChangeHasTestField(input_api, output_api):
M-A Ruel 2012/07/27 00:05:26 Do not remove it. This would break current users.
- """Requires that the changelist have a TEST= field."""
- if input_api.change.TEST:
- return []
- else:
- return [output_api.PresubmitNotifyResult(
- 'If this change requires manual test instructions to QA team, add '
- 'TEST=[instructions].')]
-
-
def CheckChangeHasBugField(input_api, output_api):
"""Requires that the changelist have a BUG= field."""
if input_api.change.BUG:
« no previous file with comments | « git_cl.py ('k') | tests/git_cl_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698