Issue 10827057: Plumb file system name down from MediaFileSystemRegistry.

Issue 10827057: Plumb file system name down from MediaFileSystemRegistry. (Closed)

Created:
8 years, 5 months ago by vandebo (ex-Chrome)

Modified:
8 years, 4 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Plumb file system name down from MediaFileSystemRegistry. Using a good name requires some refactoring in the registry which I'll do in subsequent CLs. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149272

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -34 lines)			Patch
M	chrome/browser/extensions/api/media_galleries/media_galleries_api.cc	View		1 chunk	+7 lines, -15 lines	0 comments	Download
M	chrome/browser/media_gallery/media_file_system_registry.h	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/media_gallery/media_file_system_registry.cc	View	1	4 chunks	+11 lines, -7 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_constants.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/extensions/media_gallery_custom_bindings.cc	View	1	3 chunks	+7 lines, -8 lines	0 comments	Download
M	chrome/renderer/resources/extensions/media_galleries_custom_bindings.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

https://chromiumcodereview.appspot.com/10827057/diff/1/chrome/browser/media_gallery/media_file_system_registry.cc File chrome/browser/media_gallery/media_file_system_registry.cc (right): https://chromiumcodereview.appspot.com/10827057/diff/1/chrome/browser/media_gallery/media_file_system_registry.cc#newcode102 chrome/browser/media_gallery/media_file_system_registry.cc:102: entry.name = it->first.value(); FilePath.value() is a wstring on Windows. ...

8 years, 4 months ago (2012-07-30 20:56:31 UTC) #2

vandebo (ex-Chrome)

8 years, 4 months ago (2012-07-31 18:27:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/10827057/3002

8 years, 4 months ago (2012-07-31 19:47:08 UTC) #5

Change committed as 149272

Expand Messages | Collapse Messages