Move web_contents from SearchViewController to SearchTabHelper

Move web_contents from SearchViewController to SearchTabHelper

Moves the web_contents from SearchViewController to SearchTabHelper.
This allows each NTP tab to hold its own state.

BUG=133529
TEST=Manual tests, create two new tabs, change one.  Observe differences between the two.
R=sky@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149332

[sky, 2012-07-28 02:27:53]

http://codereview.chromium.org/10827055/diff/1/chrome/browser/ui/search/searc...
File chrome/browser/ui/search/search_tab_helper.cc (right):

http://codereview.chromium.org/10827055/diff/1/chrome/browser/ui/search/searc...
chrome/browser/ui/search/search_tab_helper.cc:53:
ntp_web_contents_.reset(content::WebContents::Create(
Shouldn't we destroy this at some point? Otherwise every tab that starts at with
an NTP will always have an NTP around.

http://codereview.chromium.org/10827055/diff/1/chrome/browser/ui/search/searc...
File chrome/browser/ui/search/search_tab_helper.h (right):

http://codereview.chromium.org/10827055/diff/1/chrome/browser/ui/search/searc...
chrome/browser/ui/search/search_tab_helper.h:37: // Lazily create web contents
for NTP.
Document ownership.

http://codereview.chromium.org/10827055/diff/1/chrome/browser/ui/views/frame/...
File chrome/browser/ui/views/frame/browser_view.cc (right):

http://codereview.chromium.org/10827055/diff/1/chrome/browser/ui/views/frame/...
chrome/browser/ui/views/frame/browser_view.cc:2511:
RestackLocationBarContainer();
The comment on 2509-2510 looks like it applies to this (since it's directly
before it), but it doesn't. Maybe a newline before this? Or better yet, a
comment as to why it needs to be here.

[dhollowa, 2012-07-31 17:03:46]

http://codereview.chromium.org/10827055/diff/1/chrome/browser/ui/search/searc...
File chrome/browser/ui/search/search_tab_helper.cc (right):

http://codereview.chromium.org/10827055/diff/1/chrome/browser/ui/search/searc...
chrome/browser/ui/search/search_tab_helper.cc:53:
ntp_web_contents_.reset(content::WebContents::Create(
Yes, agreed.  I've added logic to delete the WC when the user navigates away
from the NTP and Search pages.  If the user is searching then re-searching,
this'll give them benefits of the cached WC, but they'll reclaim memory once
they're "committed".

On 2012/07/28 02:27:53, sky wrote:
> Shouldn't we destroy this at some point? Otherwise every tab that starts at
with
> an NTP will always have an NTP around.

http://codereview.chromium.org/10827055/diff/1/chrome/browser/ui/search/searc...
File chrome/browser/ui/search/search_tab_helper.h (right):

http://codereview.chromium.org/10827055/diff/1/chrome/browser/ui/search/searc...
chrome/browser/ui/search/search_tab_helper.h:37: // Lazily create web contents
for NTP.
On 2012/07/28 02:27:53, sky wrote:
> Document ownership.

Done.

http://codereview.chromium.org/10827055/diff/1/chrome/browser/ui/views/frame/...
File chrome/browser/ui/views/frame/browser_view.cc (right):

http://codereview.chromium.org/10827055/diff/1/chrome/browser/ui/views/frame/...
chrome/browser/ui/views/frame/browser_view.cc:2511:
RestackLocationBarContainer();
On 2012/07/28 02:27:53, sky wrote:
> The comment on 2509-2510 looks like it applies to this (since it's directly
> before it), but it doesn't. Maybe a newline before this? Or better yet, a
> comment as to why it needs to be here.

Done.

[sky, 2012-07-31 19:00:10]

LGTM

[commit-bot: I haz the power, 2012-07-31 23:21:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10827055/1007

[commit-bot: I haz the power, 2012-08-01 00:31:54]

Change committed as 149332