Add HostEventLogger to It2Me host plugin.

Add HostEventLogger to It2Me host plugin.

BUG=132886
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148845

[alexeypa (please no reviews), 2012-07-26 21:55:47]

PTAL. This is a reincarnation of http://codereview.chromium.org/10673018/.

This CL does the same thing plus makes sure that the message table is compiled
into remoting_me2me_host.exe. 

remoting_host_plugin.dll on the other hand does not get the message table. It is
assumed that one will need to install the me2me host in order to see the
messages in the Event log. The messages will be written to the event log
regardless whether the me2me host is installed or not.

[Lambros, 2012-07-27 16:52:26]

lgtm with nit

http://codereview.chromium.org/10827054/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10827054/diff/1/remoting/remoting.gyp#newcode920
remoting/remoting.gyp:920: },  # end of target 'remoting_client'
nit: s/remoting_client/remoting_host_event_logger

[commit-bot: I haz the power, 2012-07-27 21:59:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10827054/6001

[Sergey Ulanov, 2012-07-27 21:59:53]

http://codereview.chromium.org/10827054/diff/1/remoting/host/plugin/host_scri...
File remoting/host/plugin/host_script_object.cc (right):

http://codereview.chromium.org/10827054/diff/1/remoting/host/plugin/host_scri...
remoting/host/plugin/host_script_object.cc:41: const char kApplicationName[] =
"chromoting";
I don't think this is the name we want to use here. "chrome remote desktop"? Or
maybe "chrome remoting" if it needs to be short.

http://codereview.chromium.org/10827054/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10827054/diff/1/remoting/remoting.gyp#newcode872
remoting/remoting.gyp:872: 'target_name': 'remoting_host_event_logger',
What's the reason this can't be part of remoting_host target?

[alexeypa (please no reviews), 2012-07-27 22:10:44]

FYI.

http://codereview.chromium.org/10827054/diff/1/remoting/host/plugin/host_scri...
File remoting/host/plugin/host_script_object.cc (right):

http://codereview.chromium.org/10827054/diff/1/remoting/host/plugin/host_scri...
remoting/host/plugin/host_script_object.cc:41: const char kApplicationName[] =
"chromoting";
On 2012/07/27 21:59:53, sergeyu wrote:
> I don't think this is the name we want to use here. "chrome remote desktop"?
Or
> maybe "chrome remoting" if it needs to be short.

This name has been used in a released version of me2me host. Chanhing it will
break backward compatibility. It is not going to be a fatal breakage but still
it is not worth changing the name now.

Also this name is not user-facing and it is same as the name of the service.

http://codereview.chromium.org/10827054/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10827054/diff/1/remoting/remoting.gyp#newcode872
remoting/remoting.gyp:872: 'target_name': 'remoting_host_event_logger',
On 2012/07/27 21:59:53, sergeyu wrote:
> What's the reason this can't be part of remoting_host target?

1. We don't want this functionality to be present in the simple host.
2. Dependents of remoting_host_event_logger should not only add it to the
dependencies but also decide if they want the message table to be includes in
their resources. Blending remoting_host_event_logger into remoting_host will
make this even less obvious.

[Sergey Ulanov, 2012-07-27 22:25:28]

lgtm

[commit-bot: I haz the power, 2012-07-27 23:37:42]

Change committed as 148845