Extract Scoped{FrameBuffer,Texture}Binder and clean up TFP in VAVDA.

Extract Scoped{FrameBuffer,Texture}Binder and clean up TFP in VAVDA.

Clean up TFP in VAVDA:
- properly restore currently bound texture after binding our own
- use the extracted Binders for the above
- use glXDestroyPixmap instead of glXDestroyPixmapGLX
- do not bind texture twice

Also modify TextureImageTransportSurface to use the extracted Binders.

BUG=
TEST=manual runs of VAVDA


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148827

[Pawel Osciak, 2012-07-26 20:18:24]

piman: please review the TFP and gfx changes
brettw: please owners
fischman: FYI

[piman, 2012-07-26 20:25:03]

2 nits

https://chromiumcodereview.appspot.com/10827052/diff/1/content/common/gpu/gl_...
File content/common/gpu/gl_scoped_binders.h (right):

https://chromiumcodereview.appspot.com/10827052/diff/1/content/common/gpu/gl_...
content/common/gpu/gl_scoped_binders.h:5: #ifndef
CHROME_GPU_GL_SCOPED_BINDERS_H_
correct header guard is CONTENT_COMMON_GPU_GL_SCOPED_BINDERS_H_

https://chromiumcodereview.appspot.com/10827052/diff/1/content/common/gpu/gl_...
content/common/gpu/gl_scoped_binders.h:8: namespace gfx {
If it's here, it should be in the namespace content, not gfx.

[Pawel Osciak, 2012-07-26 20:36:48]

https://chromiumcodereview.appspot.com/10827052/diff/1/content/common/gpu/gl_...
File content/common/gpu/gl_scoped_binders.h (right):

https://chromiumcodereview.appspot.com/10827052/diff/1/content/common/gpu/gl_...
content/common/gpu/gl_scoped_binders.h:5: #ifndef
CHROME_GPU_GL_SCOPED_BINDERS_H_
On 2012/07/26 20:25:03, piman wrote:
> correct header guard is CONTENT_COMMON_GPU_GL_SCOPED_BINDERS_H_

Done. Took inspiration from the only file in this directory that had it wrong.

https://chromiumcodereview.appspot.com/10827052/diff/1/content/common/gpu/gl_...
content/common/gpu/gl_scoped_binders.h:8: namespace gfx {
On 2012/07/26 20:25:03, piman wrote:
> If it's here, it should be in the namespace content, not gfx.

Done.

[piman, 2012-07-26 20:41:06]

lgtm

[commit-bot: I haz the power, 2012-07-26 20:42:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/posciak@chromium.org/10827052/9001

[commit-bot: I haz the power, 2012-07-26 20:43:21]

Presubmit check for 10827052-9001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content

Presubmit checks took 1.2s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[brettw, 2012-07-27 20:12:08]

owners lgtm rubberstamp

[commit-bot: I haz the power, 2012-07-27 20:17:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/posciak@chromium.org/10827052/9001

[commit-bot: I haz the power, 2012-07-27 22:09:14]

Change committed as 148827