Issue 10827051: [Android] Fix ImageOperations.ResizeShouldAverageColors

Issue 10827051: [Android] Fix ImageOperations.ResizeShouldAverageColors (Closed)

Created:
8 years, 4 months ago by Yaron

Modified:
8 years, 4 months ago

Reviewers:
Nico

CC:
chromium-reviews, michaelbai

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Fix ImageOperations.ResizeShouldAverageColors Add matching OS_ANDROID guard in tests missing from http://codereview.chromium.org/10806077/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148665

Patch Set 3 : switch to linux && !gtv #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	skia/ext/image_operations.cc	View	1 2	1 chunk	+1 line, -1 line	1 comment	Download
	M	skia/ext/image_operations_unittest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Nico

http://codereview.chromium.org/10827051/diff/1/skia/ext/image_operations_unittest.cc File skia/ext/image_operations_unittest.cc (right): http://codereview.chromium.org/10827051/diff/1/skia/ext/image_operations_unittest.cc#newcode510 skia/ext/image_operations_unittest.cc:510: #if defined(OS_POSIX) && !defined(GTV) && !defined(OS_MACOSX) && !defined(OS_ANDROID) 80 ...

8 years, 4 months ago (2012-07-26 20:05:45 UTC) #2

Yaron

8 years, 4 months ago (2012-07-26 20:15:54 UTC) #3

Nico

lgtm, but lbtm with nit http://codereview.chromium.org/10827051/diff/4001/skia/ext/image_operations_unittest.cc File skia/ext/image_operations_unittest.cc (right): http://codereview.chromium.org/10827051/diff/4001/skia/ext/image_operations_unittest.cc#newcode511 skia/ext/image_operations_unittest.cc:511: !defined(OS_ANDROID) nit: Should probably ...

8 years, 4 months ago (2012-07-26 20:19:41 UTC) #4

Nico

LGTM! http://codereview.chromium.org/10827051/diff/2003/skia/ext/image_operations.cc File skia/ext/image_operations.cc (left): http://codereview.chromium.org/10827051/diff/2003/skia/ext/image_operations.cc#oldcode370 skia/ext/image_operations.cc:370: #if defined(OS_POSIX) && !defined(OS_MACOSX) && !defined(OS_ANDROID) Curious that ...

8 years, 4 months ago (2012-07-26 20:57:05 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10827051/2003

8 years, 4 months ago (2012-07-26 20:58:52 UTC) #7

Change committed as 148665

Expand Messages | Collapse Messages