Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 10827045: Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. (Closed)

Created:
8 years, 5 months ago by rpetterson
Modified:
8 years, 5 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

Removing instances of profile_->GetBookmarkModel() as part of converting BookmarkModel to a PKS. BUG=112525 TEST=unittests, manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148658

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bubble_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_sub_menu_model_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rpetterson
8 years, 5 months ago (2012-07-26 18:00:47 UTC) #1
Elliot Glaysher
lgtm
8 years, 5 months ago (2012-07-26 18:04:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlp@chromium.org/10827045/8003
8 years, 5 months ago (2012-07-26 19:50:48 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 23:47:50 UTC) #4
Change committed as 148658

Powered by Google App Engine
This is Rietveld 408576698