test/cctest/test-heap-profiler.cc - Issue 10827040: Limit initial size of hidden properties and store identity hashes inline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 10827040: Limit initial size of hidden properties and store identity hashes inline. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index 759585c1c85045f58353349b9618afe03e82a900..3e03ae96a7694f879a8181d5cc906221219dffc7 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -1468,7 +1468,7 @@ TEST(HiddenPropertiesFastCase) {

v8::Handle<v8::Value> cHandle = env->Global()->Get(v8::String::New("c"));

CHECK(!cHandle.IsEmpty() && cHandle->IsObject());

- cHandle->ToObject()->GetIdentityHash();

+ cHandle->ToObject()->SetHiddenValue(v8_str("key"), v8_str("val"));

snapshot = v8::HeapProfiler::TakeSnapshot(

v8_str("HiddenPropertiesFastCase2"));

« no previous file with comments | « test/cctest/test-heap.cc ('k') | no next file » | no next file with comments »