Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/api.cc

Issue 10827040: Limit initial size of hidden properties and store identity hashes inline. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3285 matching lines...) Expand 10 before | Expand all | Expand 10 after
3296 3296
3297 3297
3298 bool v8::Object::SetHiddenValue(v8::Handle<v8::String> key, 3298 bool v8::Object::SetHiddenValue(v8::Handle<v8::String> key,
3299 v8::Handle<v8::Value> value) { 3299 v8::Handle<v8::Value> value) {
3300 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); 3300 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
3301 ON_BAILOUT(isolate, "v8::Object::SetHiddenValue()", return false); 3301 ON_BAILOUT(isolate, "v8::Object::SetHiddenValue()", return false);
3302 ENTER_V8(isolate); 3302 ENTER_V8(isolate);
3303 i::HandleScope scope(isolate); 3303 i::HandleScope scope(isolate);
3304 i::Handle<i::JSObject> self = Utils::OpenHandle(this); 3304 i::Handle<i::JSObject> self = Utils::OpenHandle(this);
3305 i::Handle<i::String> key_obj = Utils::OpenHandle(*key); 3305 i::Handle<i::String> key_obj = Utils::OpenHandle(*key);
3306 i::Handle<i::String> key_symbol = FACTORY->LookupSymbol(key_obj);
3306 i::Handle<i::Object> value_obj = Utils::OpenHandle(*value); 3307 i::Handle<i::Object> value_obj = Utils::OpenHandle(*value);
3307 i::Handle<i::Object> result = 3308 i::Handle<i::Object> result =
3308 i::JSObject::SetHiddenProperty(self, key_obj, value_obj); 3309 i::JSObject::SetHiddenProperty(self, key_symbol, value_obj);
3309 return *result == *self; 3310 return *result == *self;
3310 } 3311 }
3311 3312
3312 3313
3313 v8::Local<v8::Value> v8::Object::GetHiddenValue(v8::Handle<v8::String> key) { 3314 v8::Local<v8::Value> v8::Object::GetHiddenValue(v8::Handle<v8::String> key) {
3314 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); 3315 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
3315 ON_BAILOUT(isolate, "v8::Object::GetHiddenValue()", 3316 ON_BAILOUT(isolate, "v8::Object::GetHiddenValue()",
3316 return Local<v8::Value>()); 3317 return Local<v8::Value>());
3317 ENTER_V8(isolate); 3318 ENTER_V8(isolate);
3318 i::Handle<i::JSObject> self = Utils::OpenHandle(this); 3319 i::Handle<i::JSObject> self = Utils::OpenHandle(this);
3319 i::Handle<i::String> key_obj = Utils::OpenHandle(*key); 3320 i::Handle<i::String> key_obj = Utils::OpenHandle(*key);
3320 i::Handle<i::Object> result(self->GetHiddenProperty(*key_obj)); 3321 i::Handle<i::String> key_symbol = FACTORY->LookupSymbol(key_obj);
3322 i::Handle<i::Object> result(self->GetHiddenProperty(*key_symbol));
3321 if (result->IsUndefined()) return v8::Local<v8::Value>(); 3323 if (result->IsUndefined()) return v8::Local<v8::Value>();
3322 return Utils::ToLocal(result); 3324 return Utils::ToLocal(result);
3323 } 3325 }
3324 3326
3325 3327
3326 bool v8::Object::DeleteHiddenValue(v8::Handle<v8::String> key) { 3328 bool v8::Object::DeleteHiddenValue(v8::Handle<v8::String> key) {
3327 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); 3329 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
3328 ON_BAILOUT(isolate, "v8::DeleteHiddenValue()", return false); 3330 ON_BAILOUT(isolate, "v8::DeleteHiddenValue()", return false);
3329 ENTER_V8(isolate); 3331 ENTER_V8(isolate);
3330 i::HandleScope scope(isolate); 3332 i::HandleScope scope(isolate);
3331 i::Handle<i::JSObject> self = Utils::OpenHandle(this); 3333 i::Handle<i::JSObject> self = Utils::OpenHandle(this);
3332 i::Handle<i::String> key_obj = Utils::OpenHandle(*key); 3334 i::Handle<i::String> key_obj = Utils::OpenHandle(*key);
3333 self->DeleteHiddenProperty(*key_obj); 3335 i::Handle<i::String> key_symbol = FACTORY->LookupSymbol(key_obj);
3336 self->DeleteHiddenProperty(*key_symbol);
3334 return true; 3337 return true;
3335 } 3338 }
3336 3339
3337 3340
3338 namespace { 3341 namespace {
3339 3342
3340 static i::ElementsKind GetElementsKindFromExternalArrayType( 3343 static i::ElementsKind GetElementsKindFromExternalArrayType(
3341 ExternalArrayType array_type) { 3344 ExternalArrayType array_type) {
3342 switch (array_type) { 3345 switch (array_type) {
3343 case kExternalByteArray: 3346 case kExternalByteArray:
(...skipping 3171 matching lines...) Expand 10 before | Expand all | Expand 10 after
6515 6518
6516 v->VisitPointers(blocks_.first(), first_block_limit_); 6519 v->VisitPointers(blocks_.first(), first_block_limit_);
6517 6520
6518 for (int i = 1; i < blocks_.length(); i++) { 6521 for (int i = 1; i < blocks_.length(); i++) {
6519 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]); 6522 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]);
6520 } 6523 }
6521 } 6524 }
6522 6525
6523 6526
6524 } } // namespace v8::internal 6527 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698