Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issue 10827026: Use NOINLINE for thread watcher and browser thread identifier (Closed)

Created:
8 years, 5 months ago by ramant (doing other things)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, MAD, jar (doing other things), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Use NOINLINE for thread watcher and browser thread identifier functions. R=eroman, jar, sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148487

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M chrome/browser/metrics/thread_watcher.cc View 1 1 chunk +10 lines, -16 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ramant (doing other things)
Small change not to inline methods that identify thread names. thanks, raman
8 years, 5 months ago (2012-07-26 00:13:53 UTC) #1
eroman
lgtm https://chromiumcodereview.appspot.com/10827026/diff/1/chrome/browser/metrics/thread_watcher.cc File chrome/browser/metrics/thread_watcher.cc (right): https://chromiumcodereview.appspot.com/10827026/diff/1/chrome/browser/metrics/thread_watcher.cc#newcode36 chrome/browser/metrics/thread_watcher.cc:36: // TODO(eroman): What is the equivalent for other ...
8 years, 5 months ago (2012-07-26 00:25:02 UTC) #2
ramant (doing other things)
https://chromiumcodereview.appspot.com/10827026/diff/1/chrome/browser/metrics/thread_watcher.cc File chrome/browser/metrics/thread_watcher.cc (right): https://chromiumcodereview.appspot.com/10827026/diff/1/chrome/browser/metrics/thread_watcher.cc#newcode36 chrome/browser/metrics/thread_watcher.cc:36: // TODO(eroman): What is the equivalent for other compilers? ...
8 years, 5 months ago (2012-07-26 00:28:40 UTC) #3
sky
LGTM
8 years, 5 months ago (2012-07-26 00:30:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10827026/7002
8 years, 5 months ago (2012-07-26 00:31:33 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-26 02:26:52 UTC) #6
Change committed as 148487

Powered by Google App Engine
This is Rietveld 408576698