Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: chrome/browser/ui/ash/tabs/dock_info_ash.cc

Issue 10827022: Fix coordinates in tab detach &drag code and multi window resizer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/tabs/dock_info.h" 5 #include "chrome/browser/ui/tabs/dock_info.h"
6 6
7 #include "ash/shell.h" 7 #include "ash/shell.h"
8 #include "ui/aura/client/screen_position_client.h"
8 #include "ui/aura/root_window.h" 9 #include "ui/aura/root_window.h"
9 #include "ui/aura/window.h" 10 #include "ui/aura/window.h"
10 #include "ui/compositor/layer.h" 11 #include "ui/compositor/layer.h"
11 12
12 // DockInfo ------------------------------------------------------------------- 13 // DockInfo -------------------------------------------------------------------
13 14
14 namespace { 15 namespace {
15 16
16 aura::Window* GetLocalProcessWindowAtPointImpl( 17 aura::Window* GetLocalProcessWindowAtPointImpl(
17 const gfx::Point& screen_point, 18 const gfx::Point& screen_point,
18 const std::set<gfx::NativeView>& ignore, 19 const std::set<gfx::NativeView>& ignore,
19 aura::Window* window) { 20 aura::Window* window) {
20 if (ignore.find(window) != ignore.end()) 21 if (ignore.find(window) != ignore.end())
21 return NULL; 22 return NULL;
22 23
23 if (!window->IsVisible()) 24 if (!window->IsVisible())
24 return NULL; 25 return NULL;
25 26
26 if (window->layer()->type() == ui::LAYER_TEXTURED) { 27 if (window->layer()->type() == ui::LAYER_TEXTURED) {
27 gfx::Point window_point(screen_point); 28 gfx::Point window_point(screen_point);
28 aura::Window::ConvertPointToWindow(ash::Shell::GetPrimaryRootWindow(), 29 aura::client::GetScreenPositionClient(window->GetRootWindow())->
29 window, 30 ConvertPointFromScreen(window, &window_point);
30 &window_point);
31 return gfx::Rect(window->bounds().size()).Contains(window_point) ? 31 return gfx::Rect(window->bounds().size()).Contains(window_point) ?
32 window : NULL; 32 window : NULL;
33 } 33 }
34 for (aura::Window::Windows::const_reverse_iterator i = 34 for (aura::Window::Windows::const_reverse_iterator i =
35 window->children().rbegin(); i != window->children().rend(); ++i) { 35 window->children().rbegin(); i != window->children().rend(); ++i) {
36 aura::Window* result = 36 aura::Window* result =
37 GetLocalProcessWindowAtPointImpl(screen_point, ignore, *i); 37 GetLocalProcessWindowAtPointImpl(screen_point, ignore, *i);
38 if (result) 38 if (result)
39 return result; 39 return result;
40 } 40 }
41 return NULL; 41 return NULL;
42 } 42 }
43 43
44 } // namespace 44 } // namespace
45 45
46 // static 46 // static
47 DockInfo DockInfo::GetDockInfoAtPoint(const gfx::Point& screen_point, 47 DockInfo DockInfo::GetDockInfoAtPoint(const gfx::Point& screen_point,
48 const std::set<gfx::NativeView>& ignore) { 48 const std::set<gfx::NativeView>& ignore) {
49 // TODO(beng): 49 // TODO(beng):
50 NOTIMPLEMENTED(); 50 NOTIMPLEMENTED();
51 return DockInfo(); 51 return DockInfo();
52 } 52 }
53 53
54 // static 54 // static
55 gfx::NativeView DockInfo::GetLocalProcessWindowAtPoint( 55 gfx::NativeView DockInfo::GetLocalProcessWindowAtPoint(
56 const gfx::Point& screen_point, 56 const gfx::Point& screen_point,
57 const std::set<gfx::NativeView>& ignore) { 57 const std::set<gfx::NativeView>& ignore) {
58 return GetLocalProcessWindowAtPointImpl( 58 return GetLocalProcessWindowAtPointImpl(
59 screen_point, ignore, ash::Shell::GetPrimaryRootWindow()); 59 screen_point, ignore, ash::Shell::GetRootWindowAt(screen_point));
60 } 60 }
61 61
62 bool DockInfo::GetWindowBounds(gfx::Rect* bounds) const { 62 bool DockInfo::GetWindowBounds(gfx::Rect* bounds) const {
63 if (!window()) 63 if (!window())
64 return false; 64 return false;
65 *bounds = window_->bounds(); 65 *bounds = window_->bounds();
66 return true; 66 return true;
67 } 67 }
68 68
69 void DockInfo::SizeOtherWindowTo(const gfx::Rect& bounds) const { 69 void DockInfo::SizeOtherWindowTo(const gfx::Rect& bounds) const {
70 window_->SetBounds(bounds); 70 window_->SetBounds(bounds);
71 } 71 }
OLDNEW
« no previous file with comments | « ash/wm/workspace/workspace_window_resizer.cc ('k') | chrome/browser/ui/views/tabs/tab_drag_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698