Remove 10.5 support, fix coordinate calls.

Remove 10.5 comment.

BUG=137676
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150353

[Robert Sesek, 2012-07-25 20:31:22]

LGTM

[commit-bot: I haz the power, 2012-07-25 20:48:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10827017/1

[commit-bot: I haz the power, 2012-07-25 21:55:56]

Try job failure for 10827017-1 (retry) on mac_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-25 22:12:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10827017/1

[commit-bot: I haz the power, 2012-07-25 23:06:38]

Try job failure for 10827017-1 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-07-25 23:14:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10827017/1

[commit-bot: I haz the power, 2012-07-26 00:29:12]

Try job failure for 10827017-1 (retry) on mac_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-26 02:54:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10827017/1

[commit-bot: I haz the power, 2012-07-26 04:20:17]

Try job failure for 10827017-1 (retry) on mac_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-26 22:01:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10827017/1

[commit-bot: I haz the power, 2012-07-26 22:49:39]

Try job failure for 10827017-1 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-07-27 20:22:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10827017/1

[commit-bot: I haz the power, 2012-07-27 21:29:22]

Try job failure for 10827017-1 (retry) on mac_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Avi (use Gerrit), 2012-07-28 16:40:06]

PTAL. Removing -insertText: kills all the mouse lock tests; I have no idea why.

[Robert Sesek, 2012-07-30 17:24:29]

lgtm

[commit-bot: I haz the power, 2012-08-07 14:03:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/10827017/15002

[commit-bot: I haz the power, 2012-08-07 15:45:35]

Change committed as 150353

[Nico, 2012-08-07 16:16:57]

https://chromiumcodereview.appspot.com/10827017/diff/15002/content/browser/re...
File content/browser/renderer_host/render_widget_host_view_mac.mm (left):

https://chromiumcodereview.appspot.com/10827017/diff/15002/content/browser/re...
content/browser/renderer_host/render_widget_host_view_mac.mm:2956: [self
insertText:string replacementRange:NSMakeRange(NSNotFound, 0)];
I think we can delete the whole method. I added it because typing would cause
bell sounds on 10.5 with every key press.

[Robert Sesek, 2012-08-07 16:18:08]

https://chromiumcodereview.appspot.com/10827017/diff/15002/content/browser/re...
File content/browser/renderer_host/render_widget_host_view_mac.mm (left):

https://chromiumcodereview.appspot.com/10827017/diff/15002/content/browser/re...
content/browser/renderer_host/render_widget_host_view_mac.mm:2956: [self
insertText:string replacementRange:NSMakeRange(NSNotFound, 0)];
On 2012/08/07 16:16:58, Nico wrote:
> I think we can delete the whole method. I added it because typing would cause
> bell sounds on 10.5 with every key press.

He did initially, but it was causing test failures.

[Nico, 2012-08-07 16:23:02]

On 2012/08/07 16:18:08, rsesek wrote:
>
https://chromiumcodereview.appspot.com/10827017/diff/15002/content/browser/re...
> File content/browser/renderer_host/render_widget_host_view_mac.mm (left):
> 
>
https://chromiumcodereview.appspot.com/10827017/diff/15002/content/browser/re...
> content/browser/renderer_host/render_widget_host_view_mac.mm:2956: [self
> insertText:string replacementRange:NSMakeRange(NSNotFound, 0)];
> On 2012/08/07 16:16:58, Nico wrote:
> > I think we can delete the whole method. I added it because typing would
cause
> > bell sounds on 10.5 with every key press.
> 
> He did initially, but it was causing test failures.

Possibly because readSelectionFromPasteboard: still calls insertText:?

(Sorry for not reading scrollback)

[Avi (use Gerrit), 2012-08-07 16:23:16]

Removing it breaks all the mouse lock tests. I haven't figured out why.