Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 10827015: login-webui: Close any bubble when window loses focus. (Closed)

Created:
8 years, 5 months ago by sadrul
Modified:
8 years, 4 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

login-webui: Close any bubble when window loses focus. If there is an error bubble on the login screen, and the user clicks on the status-tray, then the bubble should close. Instead of sending complicated messages from the UI to the login webui code, it is much simpler to just close the bubbles when the login window loses focus. BUG=127092 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/bubble.js View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sadrul
8 years, 5 months ago (2012-07-25 18:31:07 UTC) #1
sadrul
ping!
8 years, 5 months ago (2012-07-26 16:44:32 UTC) #2
sadrul
On 2012/07/26 16:44:32, sadrul wrote: > ping! ping!
8 years, 4 months ago (2012-07-27 23:19:46 UTC) #3
Nikita (slow)
lgtm sorry for delay, was at the 2 day offsite.
8 years, 4 months ago (2012-07-28 01:09:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sadrul@chromium.org/10827015/1
8 years, 4 months ago (2012-07-28 02:01:31 UTC) #5
commit-bot: I haz the power
Presubmit check for 10827015-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-28 02:01:34 UTC) #6
Nikita (slow)
Apparently there were no changes to bubble.js since JS-style checker was introduced. Sorry about that.
8 years, 4 months ago (2012-07-28 02:02:29 UTC) #7
sadrul
8 years, 4 months ago (2012-07-28 02:14:37 UTC) #8
On 2012/07/28 02:02:29, Nikita Kostylev wrote:
> Apparently there were no changes to bubble.js since JS-style checker was
> introduced. Sorry about that.

Oh, no worries. I landed manually. Thanks for review! :)

Powered by Google App Engine
This is Rietveld 408576698