Issue 10827014: The new toast 'why' string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10827014: The new toast 'why' string (Closed)

Created:
8 years, 5 months ago by cpu_(ooo_6.6-7.5)

Modified:
8 years, 4 months ago

Reviewers:
Finnur

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	chrome/app/generated_resources.grd	View		1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

cpu_(ooo_6.6-7.5)

Old CL for reference http://codereview.chromium.org/10802074/ Note that this is the only toast string in this ...

8 years, 5 months ago (2012-07-25 18:22:32 UTC) #1

Finnur

Hmm... chromium|chrome_strings.grd are meant only for strings that differ between Chrome and Chromium, usually because ...

8 years, 5 months ago (2012-07-26 13:03:25 UTC) #2

cpu_(ooo_6.6-7.5)

Not sure I follow. My other CL never landed so IDS_TRY_TOAST_SET_DEFAULT should not exist in ...

8 years, 5 months ago (2012-07-27 03:09:08 UTC) #3

Finnur

8 years, 4 months ago (2012-07-29 18:55:45 UTC) #4

OK, fine.

LGTM (sorry for the late reply, I was travelling on Fri).