[Android] Implement WebSettings.{get|set}DomStorageEnabled

[Android] Implement WebSettings.{get|set}DomStorageEnabled

BUG=none
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148953

[Satish, 2012-07-30 09:44:10]

The change itself looks good. Are there any tests available for this code so you
can verify that setting something in java updates the c++ code properly and vice
versa?

[mnaganov (inactive), 2012-07-30 13:07:31]

On 2012/07/30 09:44:10, Satish wrote:
> The change itself looks good. Are there any tests available for this code so
you
> can verify that setting something in java updates the c++ code properly and
vice
> versa?

I have tests downstream (see the downstream patch). I guess they will be
upstreamed some day.

Steve has approved the downstream patch, can you please stamp this one so I can
proceed?

[Satish, 2012-07-30 13:50:04]

LGTM

On 2012/07/30 13:07:31, Mikhail Naganov (Chromium) wrote:
> On 2012/07/30 09:44:10, Satish wrote:
> > The change itself looks good. Are there any tests available for this code so
> you
> > can verify that setting something in java updates the c++ code properly and
> vice
> > versa?
> 
> I have tests downstream (see the downstream patch). I guess they will be
> upstreamed some day.
> 
> Steve has approved the downstream patch, can you please stamp this one so I
can
> proceed?

Ok, since we don't have java test runners seems like landing the test upstream
has to wait.

[battre, 2012-07-30 15:07:07]

On 2012/07/30 13:50:04, Satish wrote:
> LGTM
> 
> On 2012/07/30 13:07:31, Mikhail Naganov (Chromium) wrote:
> > On 2012/07/30 09:44:10, Satish wrote:
> > > The change itself looks good. Are there any tests available for this code
so
> > you
> > > can verify that setting something in java updates the c++ code properly
and
> > vice
> > > versa?
> > 
> > I have tests downstream (see the downstream patch). I guess they will be
> > upstreamed some day.
> > 
> > Steve has approved the downstream patch, can you please stamp this one so I
> can
> > proceed?
> 
> Ok, since we don't have java test runners seems like landing the test upstream
> has to wait.

What is the motivation for treating DomStorage separately. On desktop Chrome we
have cookies as one content type. Would it make sense to re-use the same content
type in order to keep the two implementations closer to each other?

[mnaganov (inactive), 2012-07-30 15:15:23]

On 2012/07/30 15:07:07, battre wrote:
> On 2012/07/30 13:50:04, Satish wrote:
> > LGTM
> > 
> > On 2012/07/30 13:07:31, Mikhail Naganov (Chromium) wrote:
> > > On 2012/07/30 09:44:10, Satish wrote:
> > > > The change itself looks good. Are there any tests available for this
code
> so
> > > you
> > > > can verify that setting something in java updates the c++ code properly
> and
> > > vice
> > > > versa?
> > > 
> > > I have tests downstream (see the downstream patch). I guess they will be
> > > upstreamed some day.
> > > 
> > > Steve has approved the downstream patch, can you please stamp this one so
I
> > can
> > > proceed?
> > 
> > Ok, since we don't have java test runners seems like landing the test
upstream
> > has to wait.
> 
> What is the motivation for treating DomStorage separately. On desktop Chrome
we
> have cookies as one content type. Would it make sense to re-use the same
content
> type in order to keep the two implementations closer to each other?

That's not for Chrome for Android itself. We are re-implementing a new version
of Android WebView based on Chrome, and it has separate control mechanisms for
cookies and local storage. See
http://developer.android.com/reference/android/webkit/CookieSyncManager.html and
http://developer.android.com/reference/android/webkit/WebSettings.html#setDom...