Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: tools/isolate/run_test_cases.py

Issue 10826306: Get run_test_cases.py to fail if it fails to get the list of tests it should run. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/isolate/data/gtest_fake/gtest_fake_error.py ('k') | tools/isolate/run_test_cases_smoke_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/run_test_cases.py
diff --git a/tools/isolate/run_test_cases.py b/tools/isolate/run_test_cases.py
index 323204877a8646148d432bafce539b9af1c32a63..9beccc80696924811c95888a5ee1d1f54de57692 100755
--- a/tools/isolate/run_test_cases.py
+++ b/tools/isolate/run_test_cases.py
@@ -707,7 +707,9 @@ def main(argv):
options.shards)
if not test_cases:
- return 0
+ # If test_cases is None then there was a problem generating the tests to
+ # run, so this should be considered a failure.
+ return int(test_cases is None)
if options.no_dump:
result_file = None
« no previous file with comments | « tools/isolate/data/gtest_fake/gtest_fake_error.py ('k') | tools/isolate/run_test_cases_smoke_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698