Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3024)

Unified Diff: chrome/renderer/resources/extensions/schema_generated_bindings.js

Issue 10826295: Revert 151420 - Add documentation for filtered events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/resources/extensions/event.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/schema_generated_bindings.js
===================================================================
--- chrome/renderer/resources/extensions/schema_generated_bindings.js (revision 151420)
+++ chrome/renderer/resources/extensions/schema_generated_bindings.js (working copy)
@@ -342,20 +342,15 @@
var eventName = apiDef.namespace + "." + eventDef.name;
var customEvent = customEvents[apiDef.namespace];
- var options = eventDef.options || {};
-
- if (eventDef.filters && eventDef.filters.length > 0)
- options.supportsFilters = true;
-
if (customEvent) {
mod[eventDef.name] = new customEvent(
eventName, eventDef.parameters, eventDef.extraParameters,
- options);
+ eventDef.options);
} else if (eventDef.anonymous) {
mod[eventDef.name] = new chrome.Event();
} else {
mod[eventDef.name] = new chrome.Event(
- eventName, eventDef.parameters, options);
+ eventName, eventDef.parameters, eventDef.options);
}
});
}
« no previous file with comments | « chrome/renderer/resources/extensions/event.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698