Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: net/base/cert_verify_proc_nss.cc

Issue 10826257: Implement SHA-256 fingerprint support (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/cert_verify_proc_nss.cc
===================================================================
--- net/base/cert_verify_proc_nss.cc (revision 152095)
+++ net/base/cert_verify_proc_nss.cc (working copy)
@@ -4,6 +4,9 @@
#include "net/base/cert_verify_proc_nss.h"
+#include <string>
+#include <vector>
+
#include <cert.h>
#include <nss.h>
#include <prerror.h>
@@ -566,24 +569,35 @@
return SECOID_AddEntry(&od);
}
-SHA1Fingerprint CertPublicKeyHash(CERTCertificate* cert) {
- SHA1Fingerprint hash;
- SECStatus rv = HASH_HashBuf(HASH_AlgSHA1, hash.data,
+HashValue CertPublicKeyHashSHA1(CERTCertificate* cert) {
+ HashValue hash(HASH_VALUE_SHA1);
+ SECStatus rv = HASH_HashBuf(HASH_AlgSHA1, hash.data(),
cert->derPublicKey.data, cert->derPublicKey.len);
DCHECK_EQ(rv, SECSuccess);
return hash;
}
+HashValue CertPublicKeyHashSHA256(CERTCertificate* cert) {
+ HashValue hash(HASH_VALUE_SHA256);
+ SECStatus rv = HASH_HashBuf(HASH_AlgSHA256, hash.data(),
+ cert->derPublicKey.data, cert->derPublicKey.len);
+ DCHECK_EQ(rv, SECSuccess);
+ return hash;
+}
+
void AppendPublicKeyHashes(CERTCertList* cert_list,
CERTCertificate* root_cert,
- std::vector<SHA1Fingerprint>* hashes) {
+ HashValueVector* hashes) {
for (CERTCertListNode* node = CERT_LIST_HEAD(cert_list);
!CERT_LIST_END(node, cert_list);
node = CERT_LIST_NEXT(node)) {
- hashes->push_back(CertPublicKeyHash(node->cert));
+ hashes->push_back(CertPublicKeyHashSHA1(node->cert));
+ hashes->push_back(CertPublicKeyHashSHA256(node->cert));
}
- if (root_cert)
- hashes->push_back(CertPublicKeyHash(root_cert));
+ if (root_cert) {
+ hashes->push_back(CertPublicKeyHashSHA1(root_cert));
+ hashes->push_back(CertPublicKeyHashSHA256(root_cert));
+ }
}
// Returns true if |cert_handle| contains a policy OID that is an EV policy
@@ -671,7 +685,7 @@
return false;
}
- SHA1Fingerprint fingerprint =
+ SHA1HashValue fingerprint =
X509Certificate::CalculateFingerprint(root_ca);
return metadata->HasEVPolicyOID(fingerprint, ev_policy_oid);
}

Powered by Google App Engine
This is Rietveld 408576698