Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 10826253: Fix the browser windows from going in a loop trying to steal focus from each other when activating … (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/frame/browser_view.h
===================================================================
--- chrome/browser/ui/views/frame/browser_view.h (revision 150802)
+++ chrome/browser/ui/views/frame/browser_view.h (working copy)
@@ -176,11 +176,6 @@
// otherwise.
bool GetAccelerator(int cmd_id, ui::Accelerator* accelerator);
- // Shows the next app-modal dialog box, if there is one to be shown, or moves
- // an existing showing one to the front. Returns true if one was shown or
- // activated, false if none was shown.
- bool ActivateAppModalDialog() const;
-
// Returns the selected WebContents/TabContents. Used by our
// NonClientView's TabIconView::TabContentsProvider implementations.
// TODO(beng): exposing this here is a bit bogus, since it's only used to
@@ -562,6 +557,10 @@
// and returns true if the focus is currently on a WebContent.
bool DoCutCopyPaste(void (content::RenderWidgetHost::*method)());
+ // Shows the next app-modal dialog box, if there is one to be shown, or moves
+ // an existing showing one to the front.
+ void ActivateAppModalDialog() const;
+
// Last focused view that issued a tab traversal.
int last_focused_view_storage_id_;
@@ -715,6 +714,8 @@
scoped_ptr<SearchViewController> search_view_controller_;
#endif
+ mutable base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
+
DISALLOW_COPY_AND_ASSIGN(BrowserView);
};
« no previous file with comments | « no previous file | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698