Issue 10826253: Fix the browser windows from going in a loop trying to steal focus from each other when activating …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10826253: Fix the browser windows from going in a loop trying to steal focus from each other when activating … (Closed)

Created:
8 years, 4 months ago by jam

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix the browser windows from going in a loop trying to steal focus from each other when activating a differnet window from the one that has a modal dialog. Instead, activate it in a posttask. BUG=141650 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151211

Patch Set 1 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -21 lines)			Patch
	M	chrome/browser/ui/views/frame/browser_view.h	View		3 chunks	+6 lines, -5 lines	0 comments	Download
	M	chrome/browser/ui/views/frame/browser_view.cc	View		5 chunks	+33 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 4 months ago (2012-08-11 00:50:28 UTC) #2

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Expand Messages | Collapse Messages