Issue 10826241: File manager: use pre-bound "self" variable instead of "this".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10826241: File manager: use pre-bound "self" variable instead of "this". (Closed)

Created:
8 years, 4 months ago by kinaba

Modified:
8 years, 4 months ago

Reviewers:
SeRya

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

File manager: use pre-bound "self" variable instead of "this". The onError function is called as a free function hence has no associated "this" object. BUG=141809 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151199

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/file_manager/js/file_copy_manager.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/10826241/1

8 years, 4 months ago (2012-08-12 11:37:25 UTC) #3

Change committed as 151199