Issue 10826238: Ensure that the correct open gl context is made current before attempting to write to the open

Issue 10826238: Ensure that the correct open gl context is made current before attempting to write to the open (Closed)

Created:
8 years, 4 months ago by ananta

Modified:
8 years, 4 months ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Ensure that the correct open gl context is made current before attempting to write to the open gl textures in the DXVA decoder on windows. This fixes the problem with flashing in HTML5 videos with gpu compositing turned on. BUG=141233 R=fischman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151089

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 2

Patch Set 7 : #

Patch Set 8 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -6 lines)			Patch
M	content/common/gpu/media/dxva_video_decode_accelerator.h	View	1 2 3 4 5 6	2 chunks	+5 lines, -1 line	0 comments	Download
M	content/common/gpu/media/dxva_video_decode_accelerator.cc	View	1 2 3 4 5 6	2 chunks	+9 lines, -2 lines	0 comments	Download
M	content/common/gpu/media/gpu_video_decode_accelerator.cc	View	1 2 3 4 5 6	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/common/gpu/media/video_decode_accelerator_unittest.cc	View	1 2 3 4 5 6	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/10826238/10

8 years, 4 months ago (2012-08-10 00:03:12 UTC) #3

commit-bot: I haz the power

Try job failure for 10826238-10 (retry) on win for step "compile" (clobber build). It's a ...

8 years, 4 months ago (2012-08-10 01:11:42 UTC) #4

Ami GONE FROM CHROMIUM

https://chromiumcodereview.appspot.com/10826238/diff/10/content/common/gpu/media/video_decode_accelerator_unittest.cc File content/common/gpu/media/video_decode_accelerator_unittest.cc (right): https://chromiumcodereview.appspot.com/10826238/diff/10/content/common/gpu/media/video_decode_accelerator_unittest.cc#newcode313 content/common/gpu/media/video_decode_accelerator_unittest.cc:313: #if !defined(OS_WIN) && !defined(OS_MACOSX) && defined(ARCH_CPU_X86_FAMILY) Need to drop ...

8 years, 4 months ago (2012-08-10 02:38:22 UTC) #5

ananta

8 years, 4 months ago (2012-08-10 18:08:53 UTC) #6

https://chromiumcodereview.appspot.com/10826238/diff/10/content/common/gpu/me...
File content/common/gpu/media/video_decode_accelerator_unittest.cc (right):

https://chromiumcodereview.appspot.com/10826238/diff/10/content/common/gpu/me...
content/common/gpu/media/video_decode_accelerator_unittest.cc:313: #if
!defined(OS_WIN) && !defined(OS_MACOSX) && defined(ARCH_CPU_X86_FAMILY)
On 2012/08/10 02:38:22, Ami Fischman wrote:
> Need to drop this !defined(OS_WIN) now that you're using this function below.

Done.

Expand Messages | Collapse Messages