Issue 10826232: NaCl VS Add-in User Changed Properties Fix

Issue 10826232: NaCl VS Add-in User Changed Properties Fix (Closed)

Created:
8 years, 4 months ago by tysand

Modified:
8 years, 4 months ago

Reviewers:
noelallen1

CC:
native-client-reviews_googlegroups.com

Base URL:
https://nativeclient-sdk.googlecode.com/svn/trunk/src

Visibility:
Public.

More Reviews

Description

NaCl VS Add-in User Changed Properties Fix Fixed the NaCl compiler not reading user changed properties. Fixed several other properties not being respected if user changed. The non-compiler properties fix is a workaround for issue 140162. The compiler property issue is resolved. Added feature to convert libs between NaCl and Pepper names (.lib or no extension) BUG=136414 Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1409

Patch Set 1 #

Total comments: 4

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -51 lines)			Patch
M	visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.props	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.targets	View	4 chunks	+6 lines, -4 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Microsoft.Cpp.NaCl.default.props	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/NaCl.Paths.default.props	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/PlatformToolsets/win_x86_glibc/Microsoft.Cpp.NaCl.win_x86_glibc.props	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/PlatformToolsets/win_x86_newlib/Microsoft.Cpp.NaCl.win_x86_newlib.props	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/Properties/nacl_general.xml	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/InstallerResources/PPAPI_Patch/Microsoft.Cpp.[platform].default.props.patch	View	1 chunk	+1 line, -1 line	0 comments	Download
M	visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs	View	2 chunks	+47 lines, -0 lines	4 comments	Download
M	visual_studio/NativeClientVSAddIn/UnitTests/ProjectSettingsTest.cs	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	visual_studio/NativeClientVSAddIn/UnitTests/PropertyManagerTest.cs	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

noelallen1

A couple things to double check otherwise LGTM. http://codereview.chromium.org/10826232/diff/1/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs File visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs (right): http://codereview.chromium.org/10826232/diff/1/visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs#newcode196 visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs:196: string[] ...

8 years, 4 months ago (2012-08-09 18:19:45 UTC) #2

tysand

8 years, 4 months ago (2012-08-09 18:23:38 UTC) #3

http://codereview.chromium.org/10826232/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs (right):

http://codereview.chromium.org/10826232/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs:196: string[]
libsList = libs.Split(';');
Double checked, and Visual Studio will automatically convert to the semi-colon
delimited list if entered with newlines.
On 2012/08/09 18:19:45, noelallen1 wrote:
> Doesn't '\n' also work as a delimiter when you enter the names?  Pls double
> check.

http://codereview.chromium.org/10826232/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/Connect.cs:203: libs =
string.Concat(libs, baseLibName, ".lib;");
Verified this is a non-issue.
On 2012/08/09 18:19:45, noelallen1 wrote:
> Trailing ;?

Expand Messages | Collapse Messages