Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 10826224: Always keep track of frames even if we can't send events for them. Just don't send events. (Closed)

Created:
8 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 4 months ago
Reviewers:
marja
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Always keep track of frames even if we can't send events for them. Just don't send events. BUG=139117, 141497 TEST=WebNavigationApiTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -16 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 8 chunks +32 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
plz review
8 years, 4 months ago (2012-08-09 13:10:08 UTC) #1
marja
LGTM (CNAW (*)) (*) Can't notice anything wrong
8 years, 4 months ago (2012-08-09 13:17:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10826224/1
8 years, 4 months ago (2012-08-09 13:22:31 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 15:27:41 UTC) #4
Change committed as 150796

Powered by Google App Engine
This is Rietveld 408576698