Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 10826217: Script to archive profiling data collected from (Closed)

Created:
8 years, 4 months ago by ramant (doing other things)
Modified:
8 years, 4 months ago
Reviewers:
cmp
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Script to archive profiling data collected from startup_test into google storage. Code review URL: https://chromiumcodereview.appspot.com/10834044/ Uploading same CL as above from linux. TBR=cmp Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150642

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -0 lines) Patch
A scripts/slave/archive_profiling_data.py View 1 chunk +94 lines, -0 lines 0 comments Download
M scripts/slave/runtest.py View 2 chunks +30 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
ramant (doing other things)
8 years, 4 months ago (2012-08-09 00:01:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10826217/1
8 years, 4 months ago (2012-08-09 00:01:41 UTC) #2
cmp
lgtm
8 years, 4 months ago (2012-08-09 00:01:47 UTC) #3
commit-bot: I haz the power
Change committed as 150642
8 years, 4 months ago (2012-08-09 00:03:03 UTC) #4
cmp
https://chromiumcodereview.appspot.com/10826217/diff/1/scripts/slave/runtest.py File scripts/slave/runtest.py (right): https://chromiumcodereview.appspot.com/10826217/diff/1/scripts/slave/runtest.py#newcode417 scripts/slave/runtest.py:417: options.build_properties['buildername'], and these should be .get(), too :) https://chromiumcodereview.appspot.com/10826217/diff/1/scripts/slave/runtest.py#newcode927 ...
8 years, 4 months ago (2012-08-09 02:13:04 UTC) #5
ramant (doing other things)
8 years, 4 months ago (2012-08-09 02:18:35 UTC) #6
hi cmp,
  Checked in a change to disable uploading of profile data (deleted the new code
in runtest.py). Will submit a separate CL with .get().

thanks
raman

On 2012/08/09 02:13:04, cmp wrote:
>
https://chromiumcodereview.appspot.com/10826217/diff/1/scripts/slave/runtest.py
> File scripts/slave/runtest.py (right):
> 
>
https://chromiumcodereview.appspot.com/10826217/diff/1/scripts/slave/runtest....
> scripts/slave/runtest.py:417: options.build_properties['buildername'],
> and these should be .get(), too :)
> 
>
https://chromiumcodereview.appspot.com/10826217/diff/1/scripts/slave/runtest....
> scripts/slave/runtest.py:927: if (options.build_properties['buildername'] ==
'XP
> Perf (1)' and
> right!  this should be .get('buildername')

Powered by Google App Engine
This is Rietveld 408576698