Issue 10826214: Fix document size not changing when switching between printers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10826214: Fix document size not changing when switching between printers. (Closed)

Created:
8 years, 4 months ago by Albert Bodenhamer

Modified:
8 years, 4 months ago

Reviewers:
Robert Toscano, Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix document size not changing when switching between printers. There was an optimization in preview_generator.js that didn't request a new preview in certain cases. This CL relaxes the checks so that changing to a new printer always requests a new preview. In the case where the preview really DOESN'T need to be regenerated an optimization on the C++ side will prevent unneeded regenerations. BUG=140826 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150699

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	chrome/browser/resources/print_preview/preview_generator.js	View		1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/10826214/1

8 years, 4 months ago (2012-08-08 23:46:57 UTC) #4

commit-bot: I haz the power

Try job failure for 10826214-1 (previous was lost) (retry) on mac_rel for step "nacl_integration". It's ...

8 years, 4 months ago (2012-08-09 01:08:28 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/10826214/1

8 years, 4 months ago (2012-08-09 01:20:35 UTC) #6

Change committed as 150699

Expand Messages | Collapse Messages