Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: lib/compiler/implementation/enqueue.dart

Issue 10826204: Revert "estimating parameter types" optimization due to failure on browser (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « lib/compiler/implementation/compiler.dart ('k') | lib/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 class EnqueueTask extends CompilerTask { 5 class EnqueueTask extends CompilerTask {
6 final Enqueuer codegen; 6 final Enqueuer codegen;
7 final Enqueuer resolution; 7 final Enqueuer resolution;
8 8
9 String get name() => 'Enqueue'; 9 String get name() => 'Enqueue';
10 10
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 if (!isResolutionQueue && 81 if (!isResolutionQueue &&
82 element.kind === ElementKind.GENERATIVE_CONSTRUCTOR) { 82 element.kind === ElementKind.GENERATIVE_CONSTRUCTOR) {
83 registerInstantiatedClass(element.enclosingElement); 83 registerInstantiatedClass(element.enclosingElement);
84 } 84 }
85 if (elements === null) { 85 if (elements === null) {
86 elements = getCachedElements(element); 86 elements = getCachedElements(element);
87 } 87 }
88 queue.add(new WorkItem(element, elements)); 88 queue.add(new WorkItem(element, elements));
89 } 89 }
90 90
91 void eagerRecompile(Element element) {
92 universe.generatedCode.remove(element);
93 universe.generatedBailoutCode.remove(element);
94 addToWorkList(element);
95 }
96
97 bool canBeRecompiled(Element element) { 91 bool canBeRecompiled(Element element) {
98 // Only member functions can be recompiled. An exception to this is members 92 // Only member functions can be recompiled. An exception to this is members
99 // of closures. They are processed as part of the enclosing function and not 93 // of closures. They are processed as part of the enclosing function and not
100 // present as a separate element (the call to the closure will be a member 94 // present as a separate element (the call to the closure will be a member
101 // function). 95 // function).
102 return element.isMember() && !element.getEnclosingClass().isClosure(); 96 return element.isMember() && !element.getEnclosingClass().isClosure();
103 } 97 }
104 98
105 void registerRecompilationCandidate(Element element, 99 void registerRecompilationCandidate(Element element,
106 [TreeElements elements]) { 100 [TreeElements elements]) {
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 void registerIsCheck(Element element) { 314 void registerIsCheck(Element element) {
321 universe.isChecks.add(element); 315 universe.isChecks.add(element);
322 } 316 }
323 317
324 void forEach(f(WorkItem work)) { 318 void forEach(f(WorkItem work)) {
325 while (!queue.isEmpty()) { 319 while (!queue.isEmpty()) {
326 f(queue.removeLast()); 320 f(queue.removeLast());
327 } 321 }
328 } 322 }
329 } 323 }
OLDNEW
« no previous file with comments | « lib/compiler/implementation/compiler.dart ('k') | lib/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698