Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4091)

Unified Diff: chrome/browser/extensions/active_tab_unittest.cc

Issue 10826199: Properly propagate the current Chrome channel into the Feature system on the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/active_tab_unittest.cc
diff --git a/chrome/browser/extensions/active_tab_unittest.cc b/chrome/browser/extensions/active_tab_unittest.cc
index 35e5e48b3d7972ff49771e64f6ae7628a76bad79..20d217ae927e9d953f01e4c24038cbacde5e2293 100644
--- a/chrome/browser/extensions/active_tab_unittest.cc
+++ b/chrome/browser/extensions/active_tab_unittest.cc
@@ -58,13 +58,8 @@ class ActiveTabTest : public TabContentsTestHarness {
: extension(CreateTestExtension("deadbeef", true)),
another_extension(CreateTestExtension("feedbeef", true)),
extension_without_active_tab(CreateTestExtension("badbeef", false)),
- ui_thread_(BrowserThread::UI, MessageLoop::current()) {
- }
-
- virtual void SetUp() {
- TabContentsTestHarness::SetUp();
- Feature::SetChannelForTesting(chrome::VersionInfo::CHANNEL_UNKNOWN);
- }
+ ui_thread_(BrowserThread::UI, MessageLoop::current()),
+ current_channel_(chrome::VersionInfo::CHANNEL_UNKNOWN) {}
protected:
int tab_id() {
@@ -122,6 +117,7 @@ class ActiveTabTest : public TabContentsTestHarness {
private:
content::TestBrowserThread ui_thread_;
+ Feature::ScopedCurrentChannel current_channel_;
};
TEST_F(ActiveTabTest, GrantToSinglePage) {
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_browsertest.h » ('j') | chrome/common/extensions/features/feature.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698