Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: sync/internal_api/sync_manager_impl.cc

Issue 10826193: Remove SyncManager::Init() return value (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix CreateDirectory assertion Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/internal_api/sync_manager_impl.h ('k') | sync/internal_api/test/fake_sync_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/internal_api/sync_manager_impl.cc
diff --git a/sync/internal_api/sync_manager_impl.cc b/sync/internal_api/sync_manager_impl.cc
index 72f936f3d23a27c2d34c0c17f6cf4598b04998c2..16232f4083a8560b39ac5f26dc6074d0e55387c3 100644
--- a/sync/internal_api/sync_manager_impl.cc
+++ b/sync/internal_api/sync_manager_impl.cc
@@ -362,7 +362,7 @@ void SyncManagerImpl::ConfigureSyncer(
}
-bool SyncManagerImpl::Init(
+void SyncManagerImpl::Init(
const FilePath& database_location,
const WeakHandle<JsEventHandler>& event_handler,
const std::string& sync_server_and_path,
@@ -428,7 +428,8 @@ bool SyncManagerImpl::Init(
OnInitializationComplete(
MakeWeakHandle(weak_ptr_factory_.GetWeakPtr()),
false, syncer::ModelTypeSet()));
- return false;
+ LOG(ERROR) << "Sync manager initialization failed!";
+ return;
}
connection_manager_.reset(new SyncAPIServerConnectionManager(
@@ -495,7 +496,6 @@ bool SyncManagerImpl::Init(
OnInitializationComplete(
MakeWeakHandle(weak_ptr_factory_.GetWeakPtr()),
true, InitialSyncEndedTypes()));
- return true;
}
void SyncManagerImpl::RefreshNigori(const std::string& chrome_version,
« no previous file with comments | « sync/internal_api/sync_manager_impl.h ('k') | sync/internal_api/test/fake_sync_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698