Remove SyncManager::Init() return value

Remove SyncManager::Init() return value

The return value was almost entirely unusued.  Success or failure is
reported through a parameter in the asynchronous callback function.

BUG=140180
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150763

[rlarocque, 2012-08-08 22:05:45]

Please review.

[akalin, 2012-08-08 23:01:46]

http://codereview.chromium.org/10826193/diff/1007/chrome/browser/sync/glue/sy...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

http://codereview.chromium.org/10826193/diff/1007/chrome/browser/sync/glue/sy...
chrome/browser/sync/glue/sync_backend_host.cc:1049:
DCHECK(file_util::CreateDirectory(sync_data_folder_path_));
this is dangerous!  DCHECKs get compiled out in release builds.

[rlarocque, 2012-08-09 00:01:38]

Fixed the DCHECK issue.

http://codereview.chromium.org/10826193/diff/1007/chrome/browser/sync/glue/sy...
File chrome/browser/sync/glue/sync_backend_host.cc (right):

http://codereview.chromium.org/10826193/diff/1007/chrome/browser/sync/glue/sy...
chrome/browser/sync/glue/sync_backend_host.cc:1049:
DCHECK(file_util::CreateDirectory(sync_data_folder_path_));
On 2012/08/08 23:01:46, akalin wrote:
> this is dangerous!  DCHECKs get compiled out in release builds.

That's a very good point.  I should not put code with side-effects inside a
DCHECK.

[akalin, 2012-08-09 00:02:18]

LGTM

[commit-bot: I haz the power, 2012-08-09 00:04:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/10826193/1009

[commit-bot: I haz the power, 2012-08-09 00:57:54]

Try job failure for 10826193-1009 (retry) on mac_rel for step
"nacl_integration".
It's a second try, previously, step "nacl_integration" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-08-09 06:09:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/10826193/1009

[commit-bot: I haz the power, 2012-08-09 07:24:47]

Change committed as 150763