Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 10826181: Revert r150228 "Add support for PNG representation in gfx::Image" (Closed)

Created:
8 years, 4 months ago by oshima
Modified:
8 years, 4 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert r150228 "Add support for PNG representation in gfx::Image" Currently all conversions to or from PNG will request (and so possibly create and cache) an ImageSkia intermediate representation. Depends on http://codereview.chromium.org/10799014/ I'm reverting because this has Uninitialized issue and a test is failing on mac valgrind bots TBR=cjhopman@chromium.org BUG=123865 TEST=none NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -393 lines) Patch
M chrome/browser/ui/tests/ui_gfx_image_unittest.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/gfx/image/image.h View 4 chunks +0 lines, -9 lines 0 comments Download
M ui/gfx/image/image.cc View 11 chunks +18 lines, -197 lines 0 comments Download
D ui/gfx/image/image_mac.mm View 1 chunk +0 lines, -47 lines 0 comments Download
M ui/gfx/image/image_unittest.cc View 2 chunks +3 lines, -64 lines 0 comments Download
M ui/gfx/image/image_unittest_util.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/gfx/image/image_unittest_util.cc View 3 chunks +1 line, -40 lines 0 comments Download
D ui/gfx/image/image_unittest_util_mac.mm View 1 chunk +0 lines, -21 lines 0 comments Download
M ui/gfx/image/image_util.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M ui/ui.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
8 years, 4 months ago (2012-08-07 05:21:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10826181/1
8 years, 4 months ago (2012-08-07 05:47:41 UTC) #2
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years, 4 months ago (2012-08-07 05:58:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/10826181/1
8 years, 4 months ago (2012-08-07 07:03:34 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 07:03:46 UTC) #5
Change committed as 150294

Powered by Google App Engine
This is Rietveld 408576698