Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10826174: Dead code elimination: scythe.chrome_functions:segment.path %media% edition, round 2. (Closed)

Created:
8 years, 4 months ago by Ami GONE FROM CHROMIUM
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Dead code elimination: scythe.chrome_functions:segment.path %media% edition, round 2. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150302

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -97 lines) Patch
M content/renderer/media/mock_media_stream_dispatcher.h View 2 chunks +2 lines, -9 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/renderer/media/mock_web_peer_connection_handler_client.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/media/mock_web_peer_connection_handler_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/audio/android/audio_manager_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/android/audio_manager_android.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M media/audio/audio_manager.h View 1 chunk +0 lines, -5 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M media/audio/fake_audio_output_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/linux/alsa_output_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/audio/linux/audio_manager_linux.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/linux/audio_manager_linux.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M media/audio/linux/cras_output_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/mac/audio_manager_mac.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M media/audio/mock_audio_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/audio/mock_audio_manager.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M media/audio/openbsd/audio_manager_openbsd.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/openbsd/audio_manager_openbsd.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M media/audio/test_audio_input_controller_factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/audio/win/audio_manager_win.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/audio/win/audio_manager_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ami GONE FROM CHROMIUM
Hopefully last scythe-fueled CL for a while.
8 years, 4 months ago (2012-08-06 23:37:22 UTC) #1
scherkus (not reviewing)
LGTMMMMMMMMMMMMMMMMMMMMmmmmmmm delicious code removal
8 years, 4 months ago (2012-08-06 23:41:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10826174/1
8 years, 4 months ago (2012-08-06 23:43:08 UTC) #3
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary filesare still unsupported at ...
8 years, 4 months ago (2012-08-07 00:10:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/10826174/5004
8 years, 4 months ago (2012-08-07 06:26:58 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 07:54:23 UTC) #6 
Change committed as 150302

Powered by Google App Engine
This is Rietveld 408576698